Add MightHaveTimeGaps property to ndr.reader#89
Conversation
- Added `MightHaveTimeGaps` property to `ndr.reader.base` (default false). - Added `MightHaveTimeGaps` method to `ndr.reader` wrapper. - Set `MightHaveTimeGaps = true` in `ndr.reader.axon_abf` constructor. - Added unit test `tools/tests/+ndr/+unittest/+reader/TestMightHaveTimeGaps.m`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
stevevanhooser
deleted the
add-mighthavetimegaps-property-7966945648032242650
branch
1 participant
This change adds a
MightHaveTimeGapsproperty tondr.reader.baseand exposes it viandr.reader. This property allows readers to signal if they might produce data with time gaps. The default isfalse.ndr.reader.axon_abfis updated to set this property totrue. A unit test is added to verify the behavior.PR created automatically by Jules for task 7966945648032242650 started by @stevevanhooser