Add support for digital and analog waveform channels in abfload3#78
Draft
google-labs-jules[bot] wants to merge 9 commits intofeature-abfload3-dac-waveformsfrom
Draft
Add support for digital and analog waveform channels in abfload3#78google-labs-jules[bot] wants to merge 9 commits intofeature-abfload3-dac-waveformsfrom
google-labs-jules[bot] wants to merge 9 commits intofeature-abfload3-dac-waveformsfrom
Conversation
This commit enhances `abfload3.m` to extract and reconstruct digital and analog command waveforms from Axon Instruments ABF files. The key changes include: - Added header definitions for epoch and DAC waveform parameters for both ABFv1 and ABFv2 files. - Implemented logic to generate analog and digital command waveforms from the epoch table data. - Appended the generated waveforms as new channels to the output data matrix `d`. - Added corresponding channel names to the header structure `h`. - Added a verification script, `verify_abfload3_fix.m`, to help users test the new functionality. - Added a diagnostic script, `extract_abf_header_info.m`, to help with debugging.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
This commit enhances `abfload3.m` to extract and reconstruct digital and analog command waveforms from Axon Instruments ABF files. The key changes include: - Added header definitions for epoch and DAC waveform parameters for both ABFv1 and ABFv2 files. - Implemented logic to generate analog and digital command waveforms from the epoch table data. - Appended the generated waveforms as new channels to the output data matrix `d`. - Added corresponding channel names and units to the header structure `h`, fixing a mismatch in the number of channel names and units.
…with correct scaling This commit enhances `abfload3.m` to extract and reconstruct digital and analog command waveforms from Axon Instruments ABF files, and it corrects a scaling issue with the DAC waveform data. The key changes include: - Added header definitions for epoch and DAC waveform parameters for both ABFv1 and ABFv2 files, including DAC scaling factors and units. - Implemented logic to generate analog and digital command waveforms from the epoch table data. - Applied the correct scaling factors to the DAC waveform data to ensure the output is in the correct physical units. - Appended the generated waveforms as new channels to the output data matrix `d`. - Added corresponding channel names and units to the header structure `h`, ensuring consistency.
…with correct scaling This commit enhances `abfload3.m` to extract and reconstruct digital and analog command waveforms from Axon Instruments ABF files, and it corrects a scaling issue with the DAC waveform data. The key changes include: - Added header definitions for epoch and DAC waveform parameters for both ABFv1 and ABFv2 files, including DAC scaling factors and units. - Implemented logic to generate analog and digital command waveforms from the epoch table data. - Applied the correct scaling factors to the DAC waveform data to ensure the output is in the correct physical units. - Appended the generated waveforms as new channels to the output data matrix `d`. - Added corresponding channel names and units to the header structure `h`, ensuring consistency.
…with correct scaling This commit enhances `abfload3.m` to extract and reconstruct digital and analog command waveforms from Axon Instruments ABF files, and it corrects a scaling issue with the DAC waveform data. The key changes include: - Added header definitions for epoch and DAC waveform parameters for both ABFv1 and ABFv2 files, including DAC scaling factors and units. - Implemented logic to generate analog and digital command waveforms from the epoch table data. - Applied the correct scaling factors to the DAC waveform data to ensure the output is in the correct physical units. - Appended the generated waveforms as new channels to the output data matrix `d`. - Added corresponding channel names and units to the header structure `h`, ensuring consistency.
…with correct scaling This commit enhances `abfload3.m` to extract and reconstruct digital and analog command waveforms from Axon Instruments ABF files, and it corrects a scaling issue with the DAC waveform data. The key changes include: - Added header definitions for epoch and DAC waveform parameters for both ABFv1 and ABFv2 files, including DAC scaling factors and units. - Implemented logic to generate analog and digital command waveforms from the epoch table data. - Applied the correct scaling factors to the DAC waveform data to ensure the output is in the correct physical units. - Appended the generated waveforms as new channels to the output data matrix `d`. - Added corresponding channel names and units to the header structure `h`, ensuring consistency.
This commit fixes two critical bugs in `abfload3.m`: 1. **DAC Scaling:** The DAC waveform data is now correctly scaled using the `fDACScaleFactor` and `fDACHoldingLevel` header fields for ABFv1 files. This resolves an issue where the output data was all zeros or had extremely small values. 2. **Unit Handling:** The logic for reading DAC channel units has been improved to correctly handle blank or empty unit strings, defaulting to 'pA' in such cases. This fixes an issue where units were being displayed as `[32]`. The changes include: - Re-adding the correct DAC header field definitions for ABFv1 files. - Applying the correct scaling formula to the DAC waveform generation. - Improving the robustness of the unit string handling.
This commit fixes two critical bugs in `abfload3.m`: 1. **DAC Scaling:** The DAC waveform data is now correctly scaled using the `fDACScaleFactor` and `fDACHoldingLevel` header fields for ABFv1 files. This resolves an issue where the output data was all zeros or had extremely small values. 2. **Unit Handling:** The logic for reading DAC channel units has been improved to correctly handle blank or empty unit strings, defaulting to 'pA' in such cases. This fixes an issue where units were being displayed as `[32]`. The changes include: - Re-adding the correct DAC header field definitions for ABFv1 files. - Applying the correct scaling formula to the DAC waveform generation. - Improving the robustness of the unit string handling. - Re-creating the plotting script for verification.
This commit fixes two critical bugs in `abfload3.m`: 1. **DAC Scaling:** The DAC waveform data for ABFv1 files is now generated directly from the pre-scaled epoch levels in the header, resolving an issue where the output data was all zeros. 2. **Unit Handling:** The logic for reading DAC channel units has been improved to correctly handle blank or empty unit strings, defaulting to 'pA' in such cases. This fixes an issue where units were being displayed as `[32]`. The changes include: - Removing incorrect scaling logic for ABFv1 files. - Improving the robustness of the unit string handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This submission adds support for digital and analog waveform channels to
abfload3.m, allowing the user to extract and analyze digital current injection information from ABF files. It also includes a verification script and a diagnostic script to help with testing and debugging.PR created automatically by Jules for task 205893562343640412 started by @stevevanhooser