Skip to content

Some small fixes#365

Merged
UsernameFodder merged 2 commits intoUsernameFodder:masterfrom
Adex-8x:smol-fixes
Feb 18, 2026
Merged

Some small fixes#365
UsernameFodder merged 2 commits intoUsernameFodder:masterfrom
Adex-8x:smol-fixes

Conversation

@Adex-8x
Copy link
Contributor

@Adex-8x Adex-8x commented Feb 18, 2026

Corrects two small errors fixed that prevented CoT projects from building:

  • Adjusted the alignment of cp_context so that the size assertion succeeds
  • OS_UnLockCartridge -> OS_UnlockCartridgeVeneer

@Adex-8x
Copy link
Contributor Author

Adex-8x commented Feb 18, 2026

Symbol compatibility check fails, though I don't believe this needs an alias or anything? OS_UnLockCartridge was already invalid as a name due to case insensitivity when parsing symbols, as I eventually got symbols.asm(2976) error: Label "os_unlockcartridge" already defined when actually trying to apply a patch in CoT.

// Specifies a function called when a thread exits
typedef void (*thread_exit_fn_t)(void);

#pragma pack(4)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure you need to do

Suggested change
#pragma pack(4)
#pragma pack(push, 4)

For it to work with pop later

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, yep, that is the case. Also added another instance of this to osi_alarm

@UsernameFodder
Copy link
Owner

Symbol compatibility check fails, though I don't believe this needs an alias or anything? OS_UnLockCartridge was already invalid as a name due to case insensitivity when parsing symbols, as I eventually got symbols.asm(2976) error: Label "os_unlockcartridge" already defined when actually trying to apply a patch in CoT.

Yeah I agree, no alias is fine, feel free to ignore that check

@UsernameFodder UsernameFodder merged commit bda28d0 into UsernameFodder:master Feb 18, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants