Skip to content

Add config firework#48

Merged
Salemlumos merged 3 commits intoUselessCo:developfrom
Daksh-Aggarwal:add-config-firework
Oct 26, 2025
Merged

Add config firework#48
Salemlumos merged 3 commits intoUselessCo:developfrom
Daksh-Aggarwal:add-config-firework

Conversation

@Daksh-Aggarwal
Copy link
Contributor

Pull Request

Type of Change

  • Bug fix
  • New feature
  • Sound contribution
  • Configuration contribution
  • Documentation update
  • Other (specify)

Description

Add firework.yaml config file

Related Issue

Relates to #3

Changes Made

Add firework.yaml in src/configs/

For Sound Contributions

  • Sound is in MP3 format
  • File size is under 500KB
  • Added sound to assets/sounds/
  • Created/updated config that uses the sound

For Code Changes

  • Code follows project style
  • No console.log in production code
  • All imports have .js extensions
  • Tested locally
  • Updated documentation if needed

Screenshots/Audio

If applicable, add screenshots or audio samples (Optional: SoundCloud, YouTube, etc.).

Checklist

  • My code/contribution follows the project guidelines
  • I have tested my changes
  • I have updated documentation as needed
  • My changes don't break existing functionality

@Salemlumos
Copy link
Contributor

Hi @Daksh-Aggarwal it seems there’s a minor formatting issue. Please run npm run format to resolve it and push the changes. Thanks for your work! 🚀

@Daksh-Aggarwal
Copy link
Contributor Author

Hi @Daksh-Aggarwal it seems there’s a minor formatting issue. Please run npm run format to resolve it and push the changes. Thanks for your work! 🚀

Done!

@Daksh-Aggarwal
Copy link
Contributor Author

@marceloams Kindly merge the PR if it is appropriate.

@Salemlumos Salemlumos merged commit 11d7917 into UselessCo:develop Oct 26, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants