Skip to content

Add firework sound#47

Merged
Salemlumos merged 1 commit intoUselessCo:developfrom
Daksh-Aggarwal:add-sound-firework
Oct 26, 2025
Merged

Add firework sound#47
Salemlumos merged 1 commit intoUselessCo:developfrom
Daksh-Aggarwal:add-sound-firework

Conversation

@Daksh-Aggarwal
Copy link
Contributor

Pull Request

Type of Change

  • Bug fix
  • New feature
  • Sound contribution
  • Configuration contribution
  • Documentation update
  • Other (specify)

Description

Add firework sound to audio assets.

Related Issue

Relates #2

Changes Made

  • Add firework.mp3

For Sound Contributions

  • Sound is in MP3 format
  • File size is under 500KB
  • Added sound to assets/sounds/
  • Created/updated config that uses the sound

For Code Changes

  • Code follows project style
  • No console.log in production code
  • All imports have .js extensions
  • Tested locally
  • Updated documentation if needed

Screenshots/Audio

If applicable, add screenshots or audio samples (Optional: SoundCloud, YouTube, etc.).

Checklist

  • My code/contribution follows the project guidelines
  • I have tested my changes
  • I have updated documentation as needed
  • My changes don't break existing functionality

@Daksh-Aggarwal
Copy link
Contributor Author

@marceloams Kindly merge the PR if it is appropriate.

@Salemlumos Salemlumos merged commit 0c5d8c5 into UselessCo:develop Oct 26, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants