Skip to content

Add jazz sound file#43

Merged
marceloams merged 4 commits intoUselessCo:developfrom
APT-KK:jazz
Oct 21, 2025
Merged

Add jazz sound file#43
marceloams merged 4 commits intoUselessCo:developfrom
APT-KK:jazz

Conversation

@APT-KK
Copy link
Contributor

@APT-KK APT-KK commented Oct 19, 2025

Pull Request

Type of Change

  • Bug fix
  • New feature
  • Sound contribution
  • Configuration contribution
  • Documentation update
  • Other (specify)

Description

add jazz music

Related Issue

Closes #(issue number)

Changes Made

  • Change 1
  • Change 2
  • Change 3

For Sound Contributions

  • Sound is in MP3 format
  • File size is under 500KB
  • Added sound to assets/sounds/
  • Created/updated config that uses the sound

For Code Changes

  • Code follows project style
  • No console.log in production code
  • All imports have .js extensions
  • Tested locally
  • Updated documentation if needed

Screenshots/Audio

If applicable, add screenshots or audio samples (Optional: SoundCloud, YouTube, etc.).

Checklist

  • My code/contribution follows the project guidelines
  • I have tested my changes
  • I have updated documentation as needed
  • My changes don't break existing functionality

@marceloams
Copy link
Contributor

Hey @APT-KK! To keep files at an acceptable size, we have a 500KB max limit for sounds. Please compress your sound addition to under 500KB (or replace/remove it if compression isn't enough), then push another commit with the update. Just don't forget to add a config to use it (you can do it in this PR or create a separate one). Thanks!

@APT-KK
Copy link
Contributor Author

APT-KK commented Oct 20, 2025

@marceloams Ive compressed the audio file as per the requirements. Thank you

@marceloams
Copy link
Contributor

Hey @APT-KK! The sound looks good! I'll merge this once PR #44 (the config addition) is updated. Thanks!

@marceloams marceloams merged commit 049e2c2 into UselessCo:develop Oct 21, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants