Skip to content

Cheering Crowd sound mp3 upload#18

Open
rishaan007 wants to merge 2 commits intoUselessCo:developfrom
rishaan007:rishaan007-patch-2
Open

Cheering Crowd sound mp3 upload#18
rishaan007 wants to merge 2 commits intoUselessCo:developfrom
rishaan007:rishaan007-patch-2

Conversation

@rishaan007
Copy link
Contributor

@rishaan007 rishaan007 commented Oct 14, 2025

Pull Request

Type of Change

  • Bug fix
  • New feature
  • Sound contribution
  • Configuration contribution
  • Documentation update
  • Other (specify)

Description

I have given 2 PRs one contains mp3 file and another contains config , This is the documentation part

Related Issue

Closes #(issue number)

Changes Made

  • Change 1
  • Change 2
  • Change 3

For Sound Contributions

  • Sound is in MP3 format
  • File size is under 500KB
  • Added sound to assets/sounds/
  • Created/updated config that uses the sound

For Code Changes

  • Code follows project style
  • No console.log in production code
  • All imports have .js extensions
  • Tested locally
  • Updated documentation if needed

Screenshots/Audio

If applicable, add screenshots or audio samples (Optional: SoundCloud, YouTube, etc.).

Checklist

  • My code/contribution follows the project guidelines
  • I have tested my changes
  • I have updated documentation as needed
  • My changes don't break existing functionality

@marceloams
Copy link
Contributor

Hey @rishaan007! There's a formatting error, please run npm run format to fix it and push a new commit. Thanks!

@rishaan007
Copy link
Contributor Author

Hey @rishaan007! There's a formatting error, please run npm run format to fix it and push a new commit. Thanks!

Hello @marceloams I have formatted the code and sent you a new PR, kindly accept that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants