Skip to content

Add plugin-aio#3

Open
Karpzz wants to merge 3 commits intoUraniumCorporation:mainfrom
Karpzz:main
Open

Add plugin-aio#3
Karpzz wants to merge 3 commits intoUraniumCorporation:mainfrom
Karpzz:main

Conversation

@Karpzz
Copy link

@Karpzz Karpzz commented Feb 24, 2025

Copy link

@0xPBIT 0xPBIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of deleting the cubie plugin, you need to add yours to the list above it.

@Karpzz Karpzz requested a review from 0xPBIT February 24, 2025 21:01
@0xPBIT 0xPBIT changed the title Update index.json Add plugin-aio Feb 24, 2025
@0xPBIT
Copy link

0xPBIT commented Feb 24, 2025

Please read the requirements in your pr submission again. One of the required steps is:

You've added your entry to the beginning of the array in index.json

@0xPBIT
Copy link

0xPBIT commented Mar 12, 2025

Just a couple items for feedback in your plugin repo itself so far.

Readme Instructions

You don't need to tell people to install the package dependencies. Package managers will do this on your behalf when people install your plugin https://github.com/Karpzz/plugin-aio/blob/4e24ed4096f03c81e824a3098538191099f7fdb8/README.md?plain=1#L20-L24

Demo

Remove the demo directory from your package, your README is sufficient
https://github.com/Karpzz/plugin-aio/tree/main/demo

Magic String

move the hardcoded metaplex metadata program id string to a constant at the top of the file for clarity and maintainability.
just call it something like const METAPLEX_PROGRAM_ADDRESS and reference that in the pub key field. Just so it's named and clear. https://github.com/Karpzz/plugin-aio/blob/4e24ed4096f03c81e824a3098538191099f7fdb8/src/metadata.ts#L10-L12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants