Fix: correct console text background color #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces Palette::BackgroundApps with Palette::CodeBackground for highlighted console lines to ensure consistent background color.
|
||.text|.rodata|.bss|.data|Total (RAM)|Total (ROM)|%0A|-|-:|-:|-:|-:|-:|-:|%0A|Base|822620 bytes|478609 bytes|226512 bytes|1820 bytes|228332 bytes|1303049 bytes|%0A|Head|822612 bytes|478609 bytes|226512 bytes|1820 bytes|228332 bytes|1303041 bytes|%0A||-8 bytes|+0 bytes|+0 bytes|+0 bytes|+0 bytes|-8 bytes|%0A||-0.0 %25|+0.0 %25|+0.0 %25|+0.0 %25|+0.0 %25|-0.0 %25|%0A |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request changes the background color used behind console text lines.
Previously, non-highlighted console lines were drawn using
Palette::BackgroundApps.This caused a mismatch with the expected
Palette::CodeBackgroundused elsewhere in the Python app.Changes
console_line_cell.cpp, replaced:with:
in
ConsoleLineCell::ScrollableConsoleLineView::ConsoleLineView::drawRect().