add an option for disable shift + clear #368

cartoone222 · 2024-06-10T12:25:30Z

i have code this issue #285

github-actions · 2024-06-10T12:29:58Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	822476 bytes	478317 bytes	226520 bytes	1820 bytes	228340 bytes	1302613 bytes
Head	822644 bytes	478589 bytes	226520 bytes	1820 bytes	228340 bytes	1303053 bytes
	+168 bytes	+272 bytes	+0 bytes	+0 bytes	+0 bytes	+440 bytes
	+0.0 %	+0.1 %	+0.0 %	+0.0 %	+0.0 %	+0.0 %

Yaya-Cout

There is some things to change and I didn't built, but it looks OK.

escher/src/text_area.cpp

apps/settings/base.en.i18n

apps/global_preferences.h

Co-authored-by: Yaya-Cout <67095734+Yaya-Cout@users.noreply.github.com>

github-actions · 2024-06-18T12:34:21Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	822476 bytes	478317 bytes	226520 bytes	1820 bytes	228340 bytes	1302613 bytes
Head	822644 bytes	478589 bytes	226520 bytes	1820 bytes	228340 bytes	1303053 bytes
	+168 bytes	+272 bytes	+0 bytes	+0 bytes	+0 bytes	+440 bytes
	+0.0 %	+0.1 %	+0.0 %	+0.0 %	+0.0 %	+0.0 %

github-actions · 2024-06-18T14:04:05Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	822476 bytes	478317 bytes	226520 bytes	1820 bytes	228340 bytes	1302613 bytes
Head	822644 bytes	478589 bytes	226520 bytes	1820 bytes	228340 bytes	1303053 bytes
	+168 bytes	+272 bytes	+0 bytes	+0 bytes	+0 bytes	+440 bytes
	+0.0 %	+0.1 %	+0.0 %	+0.0 %	+0.0 %	+0.0 %

cartoone222 · 2024-06-18T14:13:43Z

i hope i havent break all

cartoone222 · 2024-06-18T14:14:41Z

cool is ok

github-actions · 2024-06-18T14:16:54Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	822476 bytes	478317 bytes	226520 bytes	1820 bytes	228340 bytes	1302613 bytes
Head	822644 bytes	478589 bytes	226520 bytes	1820 bytes	228340 bytes	1303053 bytes
	+168 bytes	+272 bytes	+0 bytes	+0 bytes	+0 bytes	+440 bytes
	+0.0 %	+0.1 %	+0.0 %	+0.0 %	+0.0 %	+0.0 %

github-actions · 2024-06-18T14:24:30Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	822476 bytes	478317 bytes	226520 bytes	1820 bytes	228340 bytes	1302613 bytes
Head	822644 bytes	478597 bytes	226520 bytes	1820 bytes	228340 bytes	1303061 bytes
	+168 bytes	+280 bytes	+0 bytes	+0 bytes	+0 bytes	+448 bytes
	+0.0 %	+0.1 %	+0.0 %	+0.0 %	+0.0 %	+0.0 %

Yaya-Cout

Also, why is it named "clearalphalockshift" ?

apps/settings/sub_menu/code_options_controller.cpp

escher/src/text_area.cpp

Co-authored-by: Yaya-Cout <67095734+Yaya-Cout@users.noreply.github.com>

cartoone222 · 2024-06-18T16:54:34Z

ok is beacaus i have change function name and e not variable name

github-actions · 2024-06-18T16:57:10Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	822476 bytes	478317 bytes	226520 bytes	1820 bytes	228340 bytes	1302613 bytes
Head	822644 bytes	478597 bytes	226520 bytes	1820 bytes	228340 bytes	1303061 bytes
	+168 bytes	+280 bytes	+0 bytes	+0 bytes	+0 bytes	+448 bytes
	+0.0 %	+0.1 %	+0.0 %	+0.0 %	+0.0 %	+0.0 %

github-actions · 2024-06-18T16:57:23Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	822476 bytes	478317 bytes	226520 bytes	1820 bytes	228340 bytes	1302613 bytes
Head	822644 bytes	478597 bytes	226520 bytes	1820 bytes	228340 bytes	1303061 bytes
	+168 bytes	+280 bytes	+0 bytes	+0 bytes	+0 bytes	+448 bytes
	+0.0 %	+0.1 %	+0.0 %	+0.0 %	+0.0 %	+0.0 %

github-actions · 2024-06-18T17:05:15Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	822476 bytes	478317 bytes	226520 bytes	1820 bytes	228340 bytes	1302613 bytes
Head	822644 bytes	478597 bytes	226520 bytes	1820 bytes	228340 bytes	1303061 bytes
	+168 bytes	+280 bytes	+0 bytes	+0 bytes	+0 bytes	+448 bytes
	+0.0 %	+0.1 %	+0.0 %	+0.0 %	+0.0 %	+0.0 %

cartoone222 · 2024-06-18T17:07:50Z

thank you for your patience I think everything is ok now

github-actions · 2024-06-18T17:08:01Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	822476 bytes	478317 bytes	226520 bytes	1820 bytes	228340 bytes	1302613 bytes
Head	822644 bytes	478597 bytes	226520 bytes	1820 bytes	228340 bytes	1303061 bytes
	+168 bytes	+280 bytes	+0 bytes	+0 bytes	+0 bytes	+448 bytes
	+0.0 %	+0.1 %	+0.0 %	+0.0 %	+0.0 %	+0.0 %

cartoone222 · 2024-09-23T19:19:55Z

why the test dosent complet ?

apps/global_preferences.h

apps/settings/base.de.i18n

apps/settings/sub_menu/code_options_controller.cpp

Co-authored-by: Quentin <github@arra.red>

cartoone222 · 2024-09-24T10:55:12Z

thx

Yaya-Cout

Please apply given suggestions before marking reviews as resolved and requesting a new review

apps/global_preferences.h

apps/settings/base.de.i18n

apps/settings/sub_menu/code_options_controller.cpp

apps/global_preferences.h

Co-authored-by: Quentin <git@quentinguidee.dev>

Co-authored-by: Yaya-Cout <67095734+Yaya-Cout@users.noreply.github.com>

github-actions · 2025-03-20T14:55:35Z

||.text|.rodata|.bss|.data|Total (RAM)|Total (ROM)|%0A|-|-:|-:|-:|-:|-:|-:|%0A|Base|822476 bytes|478317 bytes|226520 bytes|1820 bytes|228340 bytes|1302613 bytes|%0A|Head|822644 bytes|478605 bytes|226520 bytes|1820 bytes|228340 bytes|1303069 bytes|%0A||+168 bytes|+288 bytes|+0 bytes|+0 bytes|+0 bytes|+456 bytes|%0A||+0.0 %25|+0.1 %25|+0.0 %25|+0.0 %25|+0.0 %25|+0.0 %25|%0A

cartoone222 · 2025-03-20T15:05:11Z

I think i have fix all. sorry for the last time.

Yaya-Cout

I could merge the code right now, just a few i18n edits to stay consistent.

apps/settings/base.de.i18n

apps/settings/base.es.i18n

apps/settings/base.hu.i18n

apps/settings/base.it.i18n

apps/settings/base.nl.i18n

apps/settings/base.pt.i18n

apps/global_preferences.h

Co-authored-by: Yaya-Cout <67095734+Yaya-Cout@users.noreply.github.com>

cartoone222 · 2025-03-30T13:44:09Z

i have fix the name

Yaya-Cout

LGTM, I just forgot about the English translation during my last review. I've tested on the simulator, everything seems fine and ready to merge

apps/settings/base.en.i18n

cartoone222 and others added 6 commits June 4, 2024 21:38

add bgcolor to turtul module

982a6d1

add bgcolor to toolbox and a minor fix

9967c0f

ok is ok now i hope however

2bf41a2

Submodule Omega-Kawaii-Theme remove

1206511

this featurs UpsilonNumworks#285

15225a0

Merge branch 'UpsilonNumworks:upsilon-dev' into upsilon-dev

28525de

Yaya-Cout requested changes Jun 17, 2024

View reviewed changes

escher/src/text_area.cpp Outdated Show resolved Hide resolved

apps/settings/base.en.i18n Outdated Show resolved Hide resolved

apps/global_preferences.h Outdated Show resolved Hide resolved

Update escher/src/text_area.cpp casse coresction

4080824

Co-authored-by: Yaya-Cout <67095734+Yaya-Cout@users.noreply.github.com>

Merge branch 'UpsilonNumworks:upsilon-dev' into upsilon-dev

f345bdd

change name of function beacause code to late in night is bad idee

10be4b1

invation of capital letter

7604142

Yaya-Cout reviewed Jun 18, 2024

View reviewed changes

apps/settings/sub_menu/code_options_controller.cpp Outdated Show resolved Hide resolved

escher/src/text_area.cpp Outdated Show resolved Hide resolved

cartoone222 and others added 2 commits June 18, 2024 18:52

Update apps/settings/sub_menu/code_options_controller.cpp

c95c3e2

Co-authored-by: Yaya-Cout <67095734+Yaya-Cout@users.noreply.github.com>

Update escher/src/text_area.cpp

cb347d7

Co-authored-by: Yaya-Cout <67095734+Yaya-Cout@users.noreply.github.com>

cartoone222 added 2 commits June 18, 2024 19:00

im not shure all is done

1f14054

the last hiden locke

4300c42

fix UpsilonNumworks#271

ff4a801

quentinguidee suggested changes Sep 23, 2024

View reviewed changes

Update apps/global_preferences.h

1cd61ee

Co-authored-by: Quentin <github@arra.red>

cartoone222 requested a review from Yaya-Cout March 4, 2025 13:28

Yaya-Cout requested changes Mar 8, 2025

View reviewed changes

cartoone222 and others added 4 commits March 20, 2025 15:15

Update apps/settings/sub_menu/code_options_controller.cpp

85029a7

Co-authored-by: Quentin <git@quentinguidee.dev>

Update apps/global_preferences.h

9bc6c79

Co-authored-by: Yaya-Cout <67095734+Yaya-Cout@users.noreply.github.com>

Update apps/global_preferences.h

0fc48b1

Co-authored-by: Yaya-Cout <67095734+Yaya-Cout@users.noreply.github.com>

reformatting the code to meet the expected quality

1c2f6a9

cartoone222 requested a review from Yaya-Cout March 20, 2025 15:05

Yaya-Cout reviewed Mar 29, 2025

View reviewed changes

cartoone222 and others added 7 commits March 30, 2025 15:26

Update apps/settings/base.pt.i18n

d4db3c5

Co-authored-by: Yaya-Cout <67095734+Yaya-Cout@users.noreply.github.com>

Update apps/settings/base.de.i18n

e675b39

Co-authored-by: Yaya-Cout <67095734+Yaya-Cout@users.noreply.github.com>

Update apps/settings/base.es.i18n

dd8d795

Co-authored-by: Yaya-Cout <67095734+Yaya-Cout@users.noreply.github.com>

Update apps/settings/base.hu.i18n

0700c58

Co-authored-by: Yaya-Cout <67095734+Yaya-Cout@users.noreply.github.com>

Update apps/settings/base.it.i18n

e22f250

Co-authored-by: Yaya-Cout <67095734+Yaya-Cout@users.noreply.github.com>

Update apps/settings/base.nl.i18n

2f5522e

Co-authored-by: Yaya-Cout <67095734+Yaya-Cout@users.noreply.github.com>

fix nameing

058ff27

cartoone222 requested a review from Yaya-Cout March 30, 2025 13:44

Yaya-Cout approved these changes Mar 31, 2025

View reviewed changes

apps/settings/base.en.i18n Outdated Show resolved Hide resolved

Update apps/settings/base.en.i18n

620770e

Yaya-Cout merged commit 34506d3 into UpsilonNumworks:upsilon-dev Mar 31, 2025
6 of 13 checks passed

Yaya-Cout mentioned this pull request Mar 31, 2025

[apps/code] Setting to disable clear line in alpha lock shift mode #285

Closed

add an option for disable shift + clear #368

add an option for disable shift + clear #368

Uh oh!

Conversation

cartoone222 commented Jun 10, 2024

Uh oh!

github-actions bot commented Jun 10, 2024

Uh oh!

Yaya-Cout left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 18, 2024

Uh oh!

github-actions bot commented Jun 18, 2024

Uh oh!

cartoone222 commented Jun 18, 2024

Uh oh!

cartoone222 commented Jun 18, 2024

Uh oh!

github-actions bot commented Jun 18, 2024

Uh oh!

github-actions bot commented Jun 18, 2024

Uh oh!

Yaya-Cout left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cartoone222 commented Jun 18, 2024

Uh oh!

github-actions bot commented Jun 18, 2024

Uh oh!

github-actions bot commented Jun 18, 2024

Uh oh!

github-actions bot commented Jun 18, 2024

Uh oh!

cartoone222 commented Jun 18, 2024

Uh oh!

github-actions bot commented Jun 18, 2024

Uh oh!

cartoone222 commented Sep 23, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cartoone222 commented Sep 24, 2024

Uh oh!

Yaya-Cout left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 20, 2025

Uh oh!

cartoone222 commented Mar 20, 2025

Uh oh!

Yaya-Cout left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cartoone222 commented Mar 30, 2025

Uh oh!

Yaya-Cout left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!