Skip to content

Conversation

@NateWr
Copy link

@NateWr NateWr commented Feb 26, 2016

This prevents the little checkbox to show or hide advanced font options from being added to the customizer when the theme does not have any advanced options defined.

@NateWr
Copy link
Author

NateWr commented Feb 26, 2016

I went ahead and pushed another commit onto this PR just to bypass any merge conflicts from submitting two simultaneous PRs.

The second commit adds support for a default_title attribute when specifying default fonts. I feel like the long font stack string might be confusing for users and this gives me the ability to simplify things.

If you don't want the default_title support you can just cherry-pick the other commit in as desired.

@christianc1
Copy link

Sweet, thanks @NateWr. I'll review asap and update the PR.

@NateWr
Copy link
Author

NateWr commented Mar 4, 2016

Sorry for overloading this PR with different things, but I added one more commit to it which seems like a no-brainer.

@NateWr
Copy link
Author

NateWr commented Mar 15, 2016

Just touching base on this. Anything else you need from me?

@christianc1
Copy link

Hi @NateWr, sorry we sort of left you in limbo. We're really busy on some other projects but I'll take some time next week to review the PR and let you know. Until then,I'd recommend just pushing your fork up to your deployment if you haven't already. Thanks again for contributing, I'll definitely be in touch next week.

@NateWr
Copy link
Author

NateWr commented Mar 16, 2016

No worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants