Skip to content

Defender fixes#315

Open
Mygod wants to merge 2 commits intoUnownHash:mainfrom
Mygod:defender-fixes
Open

Defender fixes#315
Mygod wants to merge 2 commits intoUnownHash:mainfrom
Mygod:defender-fixes

Conversation

@Mygod
Copy link
Contributor

@Mygod Mygod commented Oct 29, 2025

Fixes #313. Can't believe we are throwing away all these data.

@Mygod
Copy link
Contributor Author

Mygod commented Oct 29, 2025

Since gmo arrives much more frequently (and this proto doesn’t even get sent by some systems/modes) we deliberately only took missing data (name, desc, and latterly defenders)

Probably the only bit in this PR that has value is being able to ignore the proto if gyms are turned off. Which I’m not sure anyone does

@jfberry Sounds like we should have timestamp gated GMO support then. The following scenario I have observed in the wild:

  1. GMO gets parsed.
  2. Gym defender gets parsed after the gym flipped.
  3. The scanner left the area and the gym has updated defender but outdated team/slot for a while.

I also turn off gym parsing for testing purposes (to reduce load) but probably not something people would really turn off.

@Mygod
Copy link
Contributor Author

Mygod commented Oct 29, 2025

Speaking of time-gating GMOs, #295 merge when?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gym defender parsing cannot be turned off

1 participant