Reverted changes to peglacimetalblock done in #71#74
Open
ChangelingRain wants to merge 2 commits intoUnknown-Anomaly:masterfrom
Open
Reverted changes to peglacimetalblock done in #71#74ChangelingRain wants to merge 2 commits intoUnknown-Anomaly:masterfrom
ChangelingRain wants to merge 2 commits intoUnknown-Anomaly:masterfrom
Conversation
…ese changes made the metal blocks no longer fit in beside peglacidrainblock, peglacimetalpanel, and peglacislopedmetal.
Contributor
Author
|
If desired, the new appearance can easily be kept by making it a new tile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes made the metal blocks no longer fit in beside peglacidrainblock, peglacimetalpanel, and peglacislopedmetal; compare before and after pictures.
The changed version of peglacimetalblock also has errors when placed diagonally and has a much more visually busy design than its related tiles.
Before(/after this pull is merged):
After(/after #71 was merged):
There are arguably two downsides to reverting these changes: peglacimetalblock will no longer be colorable(I plan to fix that and peglacimetalpanel also not being colorable.), and the pattern will be less visible(though I would argue it wasn't supposed to be especially visible.)