Fix formatting and add uom comment #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nc#25) Add the node address to runCmd error messages to make it clear which node caused the error.
Add support to use a client certificate for a secure mqtt connection. This assumes the certificates are in the node server's directory and are named with the node server's ID (uuid_slot). Add support for publishing the client connection status when we connect. This is to notify PG3 that we have connected to the mqtt broker. Publish a client disconnect status before we disconnect from the mqtt broker.
When first initializing a node, it won't be in the database so ignore the warning that it's not found in the database. This seems to confuse users who see this and assume something is wrong.
Event subscriptions take an optional parameter specifying and address filter. The purpose of this filter is to only call the event handler if the address matches the address specified when the event is published. However, only the START event includes an address when published, all other events set the address to None. The result is that if you specify an address when subscribing to any event except START, your subscription will never trigger and never call the event handler because non-None will never equal None. This wasn't really the intended behavior. Events published with address set to None were ment to apply to any/all address. This change ignores the filter address in the subscription if the the event is published with address=None. Basically all event subscriptions will trigger the handler except for START now.
Warn if the server.json file isn't available. The only thing that really depends on this is the checkProfile() method and we'd like to deprecate that eventually. Warn if no version is specified when calling the interface.start() method.
When we call PG3 to rename a node it renames the node in it's database and on the ISY. However, it also needs to update the node class object in the interface. There are also some restrictions. We shouldn't rename the node in the database or ISY if the node class object hasn't been created yet. While we're at it make sure that addNode warns about renaming the node properly. Issue: #121
addNode now takes an optional parameter; rename that can be either true or false. It defaults to false. If set to true, it will cause the node to be renamed on the ISY and in the PG3 database if using PG3 version 3.1.15 or later. Earlier versions of PG3 should ignore this parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.