Skip to content

Conversation

@dvisockas
Copy link

@dvisockas dvisockas commented Jan 16, 2026

Description

Wrapping Checkout MCP request docs in a checkout object.
Before:

{
  "id": "checkout_id",
  "line_items": {}
}

After:

{
  "id": "checkout_id",
  "checkout": {
    "line_items": {}
  }
}

Type of change

Documentation update


Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@dvisockas dvisockas requested a review from a team January 16, 2026 16:18
@google-cla
Copy link

google-cla bot commented Jan 16, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

"fulfillment": {
"methods": [
"checkout": {
"id": "checkout_abc123",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should stay a top-level field, although we also currently require it in checkout.id for update requests. @richmolj I feel we should update checkout.id to omit on update, since the transports all put ID out-of-band; what do you think?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point, changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants