Skip to content

fix: update discovery profile specification links #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0x8000-0000 wants to merge 1 commit into
base: main
Choose a base branch
from
+151 −145
Open

fix: update discovery profile specification links #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions a2a/business_agent/src/business_agent/data/agent_card.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,20 @@
{
"name": "dev.ucp.shopping.checkout",
"version": "2026-01-11",
"spec": "https://ucp.dev/specs/shopping/checkout",
"spec": "https://ucp.dev/specification/checkout",
"schema": "https://ucp.dev/schemas/shopping/checkout.json"
},
{
"name": "dev.ucp.shopping.fulfillment",
"version": "2026-01-11",
"spec": "https://ucp.dev/specs/shopping/fulfillment",
"spec": "https://ucp.dev/specification/fulfillment",
"schema": "https://ucp.dev/schemas/shopping/fulfillment.json",
"extends": "dev.ucp.shopping.checkout"
},
{
"name": "dev.ucp.shopping.discount",
"version": "2026-01-11",
"spec": "https://ucp.dev/specs/shopping/discount",
"spec": "https://ucp.dev/specification/discount",
"schema": "https://ucp.dev/schemas/shopping/discount.json",
"extends": "dev.ucp.shopping.checkout"
}
Expand Down
6 changes: 3 additions & 3 deletions a2a/business_agent/src/business_agent/data/ucp.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"services": {
"dev.ucp.shopping": {
"version": "2026-01-11",
"spec": "https://ucp.dev/specs/shopping",
"spec": "https://ucp.dev/specification/reference",
"a2a": {
"endpoint": "http://localhost:10999/.well-known/agent-card.json"
}
Expand All @@ -14,13 +14,13 @@
{
"name": "dev.ucp.shopping.checkout",
"version": "2026-01-11",
"spec": "https://ucp.dev/specs/shopping/checkout",
"spec": "https://ucp.dev/specification/checkout",
"schema": "https://ucp.dev/schemas/shopping/checkout.json"
},
{
"name": "dev.ucp.shopping.fulfillment",
"version": "2026-01-11",
"spec": "https://ucp.dev/specs/shopping/fulfillment",
"spec": "https://ucp.dev/specification/fulfillment",
"schema": "https://ucp.dev/schemas/shopping/fulfillment.json",
"extends": "dev.ucp.shopping.checkout"
}
Expand Down
8 changes: 5 additions & 3 deletions a2a/chat-client/profile/agent_profile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,26 +5,28 @@
{
"name": "dev.ucp.shopping.checkout",
"version": "2026-01-11",
"spec": "https://ucp.dev/specs/shopping/checkout",
"spec": "https://ucp.dev/specification/checkout",
"schema": "https://ucp.dev/schemas/shopping/checkout.json"
},
{
"name": "dev.ucp.shopping.fulfillment",
"version": "2026-01-11",
"spec": "https://ucp.dev/specs/shopping/fulfillment",
"spec": "https://ucp.dev/specification/fulfillment",
"schema": "https://ucp.dev/schemas/shopping/fulfillment.json",
"extends": "dev.ucp.shopping.checkout"
},
{
"name": "dev.ucp.shopping.discount",
"version": "2026-01-11",
"spec": "https://ucp.dev/specs/shopping/discount",
"spec": "https://ucp.dev/specification/discount",
"schema": "https://ucp.dev/schemas/shopping/discount.json",
"extends": "dev.ucp.shopping.checkout"
},
{
"name": "dev.ucp.shopping.buyer_consent",
"version": "2026-01-11",
"spec": "https://ucp.dev/specification/buyer_consent",
"schema": "https://ucp.dev/schemas/shopping/buyer_consent.json",
"extends": "dev.ucp.shopping.checkout"
}
]
Expand Down
76 changes: 43 additions & 33 deletions rest/nodejs/src/api/discovery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export class DiscoveryService {
services: {
'dev.ucp.shopping': {
version: this.ucpVersion,
spec: 'https://ucp.dev/specs/shopping',
spec: 'https://ucp.dev/services/shopping/rest.openapi.json',
rest: {
schema: 'https://ucp.dev/services/shopping/openapi.json',
Copy link

@oluwatimio oluwatimio Jan 14, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is also outdated in main branch @0x8000-0000 also get a 404 here. Should it be https://ucp.dev/services/shopping/rest.openapi.json?

Copy link
Contributor Author

@0x8000-0000 0x8000-0000 Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jingyli - WDYT?

Copy link
Contributor

@jingyli jingyli Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please update the schema URI here to https://ucp.dev/services/shopping/rest.openapi.json

Thanks @oluwatimio for catching it!

Copy link
Contributor Author

@0x8000-0000 0x8000-0000 Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jingyli - then should https://github.com/Universal-Commerce-Protocol/samples/blob/main/rest/python/server/routes/discovery_profile.json#L7 be updated too?

Copy link
Contributor

@jingyli jingyli Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I have just created #29 to make the update, PTAL!

endpoint: 'http://localhost:3000',
Expand All @@ -41,54 +41,33 @@ export class DiscoveryService {
{
name: 'dev.ucp.shopping.checkout',
version: this.ucpVersion,
spec: 'https://ucp.dev/specs/shopping/checkout',
spec: 'https://ucp.dev/specification/checkout',
schema: 'https://ucp.dev/schemas/shopping/checkout.json',
},
{
name: 'dev.ucp.shopping.order',
version: this.ucpVersion,
spec: 'https://ucp.dev/specs/shopping/order',
spec: 'https://ucp.dev/specification/order',
schema: 'https://ucp.dev/schemas/shopping/order.json',
},
{
name: 'dev.ucp.shopping.refund',
version: this.ucpVersion,
spec: 'https://ucp.dev/specs/shopping/refund',
schema: 'https://ucp.dev/schemas/shopping/refund.json',
extends: 'dev.ucp.shopping.order',
},
{
name: 'dev.ucp.shopping.return',
version: this.ucpVersion,
spec: 'https://ucp.dev/specs/shopping/return',
schema: 'https://ucp.dev/schemas/shopping/return.json',
extends: 'dev.ucp.shopping.order',
},
{
name: 'dev.ucp.shopping.dispute',
version: this.ucpVersion,
spec: 'https://ucp.dev/specs/shopping/dispute',
schema: 'https://ucp.dev/schemas/shopping/dispute.json',
extends: 'dev.ucp.shopping.order',
},
{
name: 'dev.ucp.shopping.discount',
version: this.ucpVersion,
spec: 'https://ucp.dev/specs/shopping/discount',
spec: 'https://ucp.dev/specification/discount',
schema: 'https://ucp.dev/schemas/shopping/discount.json',
extends: 'dev.ucp.shopping.checkout',
},
{
name: 'dev.ucp.shopping.fulfillment',
version: this.ucpVersion,
spec: 'https://ucp.dev/specs/shopping/fulfillment',
spec: 'https://ucp.dev/specification/fulfillment',
schema: 'https://ucp.dev/schemas/shopping/fulfillment.json',
extends: 'dev.ucp.shopping.checkout',
},
{
name: 'dev.ucp.shopping.buyer_consent',
version: this.ucpVersion,
spec: 'https://ucp.dev/specs/shopping/buyer_consent',
spec: 'https://ucp.dev/specification/buyer_consent',
schema: 'https://ucp.dev/schemas/shopping/buyer_consent.json',
extends: 'dev.ucp.shopping.checkout',
},
Expand All @@ -113,16 +92,47 @@ export class DiscoveryService {
{
id: 'google_pay',
name: 'google.pay',
version: '1.0',
spec: 'https://example.com/spec',
config_schema: 'https://example.com/schema',
instrument_schemas: [],
config: {},
version: '2026-01-11',
spec: 'https://developers.google.com/merchant/ucp/guides/gpay-payment-handler',
config_schema:
'https://pay.google.com/gp/p/ucp/2026-01-11/schemas/gpay_config.json',
instrument_schemas: [
'https://pay.google.com/gp/p/ucp/2026-01-11/schemas/gpay_card_payment_instrument.json',
],
config: {
api_version: 2,
api_version_minor: 0,
merchant_info: {
merchant_name: 'Flower Shop',
merchant_id: 'TEST',
merchant_origin: 'localhost',
},
allowed_payment_methods: [
{
type: 'CARD',
parameters: {
allowedAuthMethods: ['PAN_ONLY', 'CRYPTOGRAM_3DS'],
allowedCardNetworks: ['VISA', 'MASTERCARD'],
},
tokenization_specification: [
{
type: 'PAYMENT_GATEWAY',
parameters: [
{
gateway: 'example',
gatewayMerchantId: 'exampleGatewayMerchantId',
},
],
},
],
},
],
},
},
{
id: 'mock_payment_handler',
name: 'dev.ucp.mock_payment',
version: '1.0',
version: '2026-01-11',
spec: 'https://ucp.dev/specs/mock',
config_schema: 'https://ucp.dev/schemas/mock.json',
instrument_schemas: [
Expand Down
Loading