fix: add .js extensions to ESM exports for Node.js resolution #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The ESM build at
dist/esm/index.jsexports without.jsextensions:This causes Node.js ESM resolution to fail with errors like:
Solution
Add explicit
.jsextensions to all ESM import/export paths. TypeScript preserves these extensions in the compiled output, allowing Node.js ESM to resolve modules correctly.Changes
index.ts: Added.jsextension to exportssrc/extensions.ts: Added.jsextension tospec_generatedimportTesting
After this fix, ESM imports work correctly:
node --input-type=module -e "import * as sdk from './dist/esm/index.js'; console.log(Object.keys(sdk).length);"