Fixed UI scaling bug for different aspect ratios#530
Open
sarahvdr wants to merge 1 commit intoUnityTechnologies:mainfrom
Open
Fixed UI scaling bug for different aspect ratios#530sarahvdr wants to merge 1 commit intoUnityTechnologies:mainfrom
sarahvdr wants to merge 1 commit intoUnityTechnologies:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #518.
To fix it, I made a new script, UIScaling.cs, and attached it to the Canvas object which contains the loading screen. In this script, I gets the screen's width and height, and readjust the canvas size to reference this size and scale to it, so that it works for any resolution.
Here is a video demonstrating this fix, where I load the loading screen in first 16:9 aspect ratio, then 21:9 aspect ratio, then 21:5 aspect ratio. For all ratios, the loading screen looked the same, demonstrating how it now scales properly for all kinds of displays.
https://user-images.githubusercontent.com/73858910/233741803-7608340c-85b0-46cf-a1c4-b2fcb2337ded.mp4