Closed Captioning system for SFX#498
Open
codeedward wants to merge 11 commits intoUnityTechnologies:mainfrom
Open
Closed Captioning system for SFX#498codeedward wants to merge 11 commits intoUnityTechnologies:mainfrom
codeedward wants to merge 11 commits intoUnityTechnologies:mainfrom
Conversation
…Needs refactoring.
…audio sfx event. Add object pooling.
…e. Remove an event channel for the captioning setting change. Instead reference SettingsSO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added Closed Captioning system for SFX. All my journey, considerations, screenshots and final video which presents the functionality in the game is available in the forum thread (link below):
https://forum.unity.com/threads/subtitle-system-for-sfx.1038562/
What is added:
Quick description:
I had a great fun creating this. Not mentioning I've learned a lot! Hope this will be useful.