Conversation
gretzke
reviewed
Jul 8, 2025
| ## Testing | ||
|
|
||
| The following testing practices should be followed when writing unit tests for new code. All functions, lines and branches should be tested to result in 100% testing coverage. Fuzz parameters and conditions whenever possible. Extremes should be tested in dedicated edge case and corner case tests. Invariants should be tested in dedicated invariant tests. | ||
| The following testing practices should be followed when writing unit tests for new code: |
Collaborator
There was a problem hiding this comment.
come back and expand the testing conventions
zhongeric
reviewed
Jul 8, 2025
|
|
||
| Tests should follow clear naming principles to easily understand the purpose of the test: | ||
| - The test itself (or the contract of the test) should include the name of the function it is testing. | ||
| - When a test checks for a revert, the test name should start with `test_revert_` or `testRevert`. |
There was a problem hiding this comment.
what about when you want to test that it reverts with a specific error?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Adding some test naming convention