Skip to content

test: mark functions not modifying state as pure#294

Open
thelostone-mc wants to merge 1 commit intoUniswap:mainfrom
thelostone-mc:test/pure-functions
Open

test: mark functions not modifying state as pure#294
thelostone-mc wants to merge 1 commit intoUniswap:mainfrom
thelostone-mc:test/pure-functions

Conversation

@thelostone-mc
Copy link

Description

Functions in test which do not modify state can be set to pure

How Has This Been Tested?

forge test

Checklist:

Before deployment

  • 100% test and branch coverage
  • check slither for severe issues
  • fuzz and invariant tests (when applicable)
  • formal verification (when applicable)
  • deployment or upgrade scripts ready

After deployment

  • transfer ownership after deployments (when applicable)
  • complete upgrade (when applicable)
  • generate deployment/upgrade log files

Considerations

  • I have followed the contributing guidelines.
  • My code follows the style guidelines of this project and I have run forge fmt and prettier to ensure the code style is valid
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional context

Add any other context about the pull request here.

@thelostone-mc thelostone-mc requested a review from a team as a code owner November 17, 2025 11:30
@zhongeric
Copy link
Contributor

Ah, can you sign your commits please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants