test: mark functions not modifying state as pure#294
Open
thelostone-mc wants to merge 1 commit intoUniswap:mainfrom
Open
test: mark functions not modifying state as pure#294thelostone-mc wants to merge 1 commit intoUniswap:mainfrom
thelostone-mc wants to merge 1 commit intoUniswap:mainfrom
Conversation
zhongeric
approved these changes
Nov 28, 2025
Contributor
|
Ah, can you sign your commits please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Functions in test which do not modify state can be set to pure
How Has This Been Tested?
forge testChecklist:
Before deployment
After deployment
Considerations
forge fmtand prettier to ensure the code style is validAdditional context
Add any other context about the pull request here.