Refactor card details link in partial_card.html #708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheenarbw
requested changes
Mar 13, 2024
Collaborator
sheenarbw
left a comment
sheenarbw
left a comment
There was a problem hiding this comment.
I'm sure there is a better way. This is "fixed" for now but it'll need to be fixed again as soon as we implement other pages. Chances are it'll confuse someone down the line or act as a bug because maybe we wont remember to fix it again.
|
|
||
| <div class="grid grid-cols-2 grid-auto-rows-1fr gap-x-10 gap-y-10 w-full h-[auto]"> | ||
| <div class="col-span-1 row-span-1 w-full"> | ||
| {%if card.content_item.content_type_nice == "project" and card.content_item.project_submission_type_nice == "link" %} |
Collaborator
There was a problem hiding this comment.
This will need to be fixed again as soon as the topic details page is in place.
Why not rather fix it in a perminant way?
You can make placeholder views for the different types of content and then the link can go there. And then the actual pages can get implemented later.
If you fix something in a way that means you need to fix it again later, is it really fixed? Let's steer clear of duct-tape
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues: [please specify]
Description:
What are you up to? Fill us in :)
Screenshots/videos
I solemnly swear that: