Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @UmairJibran, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request focuses on migrating the project to use submodules for waltzes-python and waltzes-web-server. It involves adding a .gitmodules file to define the submodules and removing several files and configurations from the main repository, presumably because they are now managed within the submodules. Specifically, .env.example, .gitignore, .prettierrc, .vscode/launch.json, Dockerfile, eslint.config.mjs, nest-cli.json, package.json, and several .ts and .spec.ts files are removed from the node-server directory.
Highlights
- Submodule Migration: The project is being restructured to utilize Git submodules for better organization and separation of concerns, specifically for
waltzes-pythonandwaltzes-web-server. - Configuration Removal: Numerous configuration files and related code have been removed from the
node-serverdirectory, indicating that these aspects are now managed within thewaltzes-pythonandwaltzes-web-serversubmodules. - Dependency Management: The
package.jsonfile, along with other build and configuration files, has been removed, suggesting a shift in how dependencies and build processes are handled, likely within the submodules.
Changelog
Click here to see the changelog
- .gitmodules
- Added a new
.gitmodulesfile to define thewaltzes-pythonandwaltzes-web-serversubmodules, specifying their paths and URLs.
- Added a new
- node-server/.env.example
- Removed the
.env.examplefile, indicating that environment variable configurations are now managed elsewhere.
- Removed the
- node-server/.gitignore
- Removed the
.gitignorefile, suggesting that ignore rules are now handled within the submodule or a different configuration.
- Removed the
- node-server/.prettierrc
- Removed the
.prettierrcfile, indicating that code formatting rules are now managed within the submodule or a different configuration.
- Removed the
- node-server/.vscode/launch.json
- Removed the
.vscode/launch.jsonfile, suggesting that debugging configurations are now managed within the submodule or a different configuration.
- Removed the
- node-server/Dockerfile
- Removed the
Dockerfile, indicating that the Docker build process is now managed within the submodule or a different configuration.
- Removed the
- node-server/eslint.config.mjs
- Removed the
eslint.config.mjsfile, indicating that ESLint configurations are now managed within the submodule or a different configuration.
- Removed the
- node-server/nest-cli.json
- Removed the
nest-cli.jsonfile, suggesting that NestJS CLI configurations are now managed within the submodule or a different configuration.
- Removed the
- node-server/package.json
- Removed the
package.jsonfile, indicating that dependency management is now handled within the submodule or a different configuration.
- Removed the
- node-server/src/_internal/_internal.controller.spec.ts
- Removed the
_internal.controller.spec.tsfile, suggesting that tests related to internal controllers are now managed within the submodule.
- Removed the
- node-server/src/_internal/_internal.controller.ts
- Removed the
_internal.controller.tsfile, indicating that internal controllers are now managed within the submodule.
- Removed the
- node-server/src/app.controller.spec.ts
- Removed the
app.controller.spec.tsfile, suggesting that tests related to the main application controller are now managed within the submodule.
- Removed the
- node-server/src/app.controller.ts
- Removed the
app.controller.tsfile, indicating that the main application controller is now managed within the submodule.
- Removed the
- node-server/src/app.module.ts
- Removed the
app.module.tsfile, indicating that the main application module is now managed within the submodule.
- Removed the
- node-server/src/app.service.ts
- Removed the
app.service.tsfile, indicating that the main application service is now managed within the submodule.
- Removed the
- node-server/src/applications/applications.controller.spec.ts
- Removed the
applications.controller.spec.tsfile, suggesting that tests related to application controllers are now managed within the submodule.
- Removed the
- node-server/src/applications/applications.controller.ts
- Removed the
applications.controller.tsfile, indicating that application controllers are now managed within the submodule.
- Removed the
- node-server/src/applications/applications.module.ts
- Removed the
applications.module.tsfile, indicating that the application module is now managed within the submodule.
- Removed the
- node-server/src/applications/applications.service.spec.ts
- Removed the
applications.service.spec.tsfile, suggesting that tests related to application services are now managed within the submodule.
- Removed the
- node-server/src/applications/applications.service.ts
- Removed the
applications.service.tsfile, indicating that application services are now managed within the submodule.
- Removed the
- node-server/src/applications/dto/create-application.dto.ts
- Removed the
create-application.dto.tsfile, indicating that the DTO for creating applications is now managed within the submodule.
- Removed the
- node-server/src/applications/dto/update-application.dto.ts
- Removed the
update-application.dto.tsfile, indicating that the DTO for updating applications is now managed within the submodule.
- Removed the
- node-server/src/applications/entities/application.entity.ts
- Removed the
application.entity.tsfile, indicating that the application entity is now managed within the submodule.
- Removed the
- node-server/src/applications/schemas/application.schema.ts
- Removed the
application.schema.tsfile, indicating that the application schema is now managed within the submodule.
- Removed the
- node-server/src/auth/auth.controller.spec.ts
- Removed the
auth.controller.spec.tsfile, suggesting that tests related to authentication controllers are now managed within the submodule.
- Removed the
- node-server/src/auth/auth.controller.ts
- Removed the
auth.controller.tsfile, indicating that authentication controllers are now managed within the submodule.
- Removed the
- node-server/src/auth/auth.guard.ts
- Removed the
auth.guard.tsfile, indicating that authentication guards are now managed within the submodule.
- Removed the
- node-server/src/auth/auth.module.ts
- Removed the
auth.module.tsfile, indicating that the authentication module is now managed within the submodule.
- Removed the
- node-server/src/auth/auth.service.spec.ts
- Removed the
auth.service.spec.tsfile, suggesting that tests related to authentication services are now managed within the submodule.
- Removed the
- node-server/src/auth/auth.service.ts
- Removed the
auth.service.tsfile, indicating that authentication services are now managed within the submodule.
- Removed the
- node-server/src/auth/constants.ts
- Removed the
constants.tsfile, indicating that authentication constants are now managed within the submodule.
- Removed the
- node-server/src/auth/dto/login-user.dto.ts
- Removed the
login-user.dto.tsfile, indicating that the DTO for logging in users is now managed within the submodule.
- Removed the
- node-server/src/auth/dto/register-user.dto.ts
- Removed the
register-user.dto.tsfile, indicating that the DTO for registering users is now managed within the submodule.
- Removed the
- node-server/src/auth/types/jwt.d.ts
- Removed the
jwt.d.tsfile, indicating that JWT type definitions are now managed within the submodule.
- Removed the
- node-server/src/aws/s3/s3.module.ts
- Removed the
s3.module.tsfile, indicating that the S3 module is now managed within the submodule.
- Removed the
- node-server/src/aws/s3/s3.service.spec.ts
- Removed the
s3.service.spec.tsfile, suggesting that tests related to S3 services are now managed within the submodule.
- Removed the
- node-server/src/aws/s3/s3.service.ts
- Removed the
s3.service.tsfile, indicating that S3 services are now managed within the submodule.
- Removed the
- node-server/src/aws/ses/ses.module.ts
- Removed the
ses.module.tsfile, indicating that the SES module is now managed within the submodule.
- Removed the
- node-server/src/aws/ses/ses.service.spec.ts
- Removed the
ses.service.spec.tsfile, suggesting that tests related to SES services are now managed within the submodule.
- Removed the
- node-server/src/aws/ses/ses.service.ts
- Removed the
ses.service.tsfile, indicating that SES services are now managed within the submodule.
- Removed the
- node-server/src/aws/sqs-consumer/sqs-consumer.module.ts
- Removed the
sqs-consumer.module.tsfile, indicating that the SQS consumer module is now managed within the submodule.
- Removed the
- node-server/src/aws/sqs-consumer/sqs-consumer.service.spec.ts
- Removed the
sqs-consumer.service.spec.tsfile, suggesting that tests related to SQS consumer services are now managed within the submodule.
- Removed the
- node-server/src/aws/sqs-consumer/sqs-consumer.service.ts
- Removed the
sqs-consumer.service.tsfile, indicating that SQS consumer services are now managed within the submodule.
- Removed the
- node-server/src/aws/sqs-producer/constant.ts
- Removed the
constant.tsfile, indicating that SQS producer constants are now managed within the submodule.
- Removed the
- node-server/src/aws/sqs-producer/sqs-producer.module.ts
- Removed the
sqs-producer.module.tsfile, indicating that the SQS producer module is now managed within the submodule.
- Removed the
- node-server/src/aws/sqs-producer/sqs-producer.service.spec.ts
- Removed the
sqs-producer.service.spec.tsfile, suggesting that tests related to SQS producer services are now managed within the submodule.
- Removed the
- node-server/src/aws/sqs-producer/sqs-producer.service.ts
- Removed the
sqs-producer.service.tsfile, indicating that SQS producer services are now managed within the submodule.
- Removed the
- node-server/src/common/exceptions/application.exceptions.ts
- Removed the
application.exceptions.tsfile, indicating that application-specific exceptions are now managed within the submodule.
- Removed the
- node-server/src/common/filters/http-exception.filter.ts
- Removed the
http-exception.filter.tsfile, indicating that HTTP exception filters are now managed within the submodule.
- Removed the
- node-server/src/common/interceptors/transform.interceptor.ts
- Removed the
transform.interceptor.tsfile, indicating that transform interceptors are now managed within the submodule.
- Removed the
- node-server/src/common/types/api-response.ts
- Removed the
api-response.tsfile, indicating that API response types are now managed within the submodule.
- Removed the
- node-server/src/config.ts
- Removed the
config.tsfile, indicating that application configurations are now managed within the submodule.
- Removed the
- node-server/src/jobs/dto/create-job.dto.ts
- Removed the
create-job.dto.tsfile, indicating that the DTO for creating jobs is now managed within the submodule.
- Removed the
- node-server/src/jobs/dto/update-job.dto.ts
- Removed the
update-job.dto.tsfile, indicating that the DTO for updating jobs is now managed within the submodule.
- Removed the
- node-server/src/jobs/entities/job.entity.ts
- Removed the
job.entity.tsfile, indicating that the job entity is now managed within the submodule.
- Removed the
- node-server/src/jobs/jobs.module.ts
- Removed the
jobs.module.tsfile, indicating that the jobs module is now managed within the submodule.
- Removed the
- node-server/src/jobs/jobs.service.spec.ts
- Removed the
jobs.service.spec.tsfile, suggesting that tests related to job services are now managed within the submodule.
- Removed the
- node-server/src/jobs/jobs.service.ts
- Removed the
jobs.service.tsfile, indicating that job services are now managed within the submodule.
- Removed the
- node-server/src/jobs/schemas/job.schema.ts
- Removed the
job.schema.tsfile, indicating that the job schema is now managed within the submodule.
- Removed the
- node-server/src/main.ts
- Removed the
main.tsfile, indicating that the main application entry point is now managed within the submodule.
- Removed the
- node-server/src/subscriptions/dto/create-subscription.dto.ts
- Removed the
create-subscription.dto.tsfile, indicating that the DTO for creating subscriptions is now managed within the submodule.
- Removed the
- node-server/src/subscriptions/schema/subscription.schema.ts
- Removed the
subscription.schema.tsfile, indicating that the subscription schema is now managed within the submodule.
- Removed the
- node-server/src/subscriptions/subscriptions.module.ts
- Removed the
subscriptions.module.tsfile, indicating that the subscriptions module is now managed within the submodule.
- Removed the
- node-server/src/subscriptions/subscriptions.service.spec.ts
- Removed the
subscriptions.service.spec.tsfile, suggesting that tests related to subscription services are now managed within the submodule.
- Removed the
- node-server/src/subscriptions/subscriptions.service.ts
- Removed the
subscriptions.service.tsfile, indicating that subscription services are now managed within the submodule.
- Removed the
- node-server/src/types.d.ts
- Removed the
types.d.tsfile, indicating that type definitions are now managed within the submodule.
- Removed the
- node-server/src/users/dto/create-user.dto.ts
- Removed the
create-user.dto.tsfile, indicating that the DTO for creating users is now managed within the submodule.
- Removed the
- node-server/src/users/dto/update-user.dto.ts
- Removed the
update-user.dto.tsfile, indicating that the DTO for updating users is now managed within the submodule.
- Removed the
- node-server/src/users/entities/user.entity.ts
- Removed the
user.entity.tsfile, indicating that the user entity is now managed within the submodule.
- Removed the
- node-server/src/users/schemas/user.schema.ts
- Removed the
user.schema.tsfile, indicating that the user schema is now managed within the submodule.
- Removed the
- node-server/src/users/users.controller.spec.ts
- Removed the
users.controller.spec.tsfile, suggesting that tests related to user controllers are now managed within the submodule.
- Removed the
- node-server/src/users/users.controller.ts
- Removed the
users.controller.tsfile, indicating that user controllers are now managed within the submodule.
- Removed the
- node-server/src/users/users.module.ts
- Removed the
users.module.tsfile, indicating that the users module is now managed within the submodule.
- Removed the
- node-server/src/users/users.service.spec.ts
- Removed the
users.service.spec.tsfile, suggesting that tests related to user services are now managed within the submodule.
- Removed the
- node-server/src/users/users.service.ts
- Removed the
users.service.tsfile, indicating that user services are now managed within the submodule.
- Removed the
- node-server/test/app.e2e-spec.ts
- Removed the
app.e2e-spec.tsfile, suggesting that end-to-end tests are now managed within the submodule.
- Removed the
- node-server/test/jest-e2e.json
- Removed the
jest-e2e.jsonfile, indicating that end-to-end test configurations are now managed within the submodule.
- Removed the
- node-server/tsconfig.build.json
- Removed the
tsconfig.build.jsonfile, indicating that TypeScript build configurations are now managed within the submodule.
- Removed the
- node-server/tsconfig.json
- Removed the
tsconfig.jsonfile, indicating that TypeScript configurations are now managed within the submodule.
- Removed the
- python/.dockerignore
- Added
.env.exampleto the.dockerignorefile.
- Added
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A module's journey, a submodule's grace,
From the main repo, a new embrace.
Configurations shift, dependencies roam,
In Git's subfolder, a separate home.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.