#47 empty headers in admin #48
Conversation
Merge develop from uma-tech parrot
Codecov Report
@@ Coverage Diff @@
## develop #48 +/- ##
===========================================
+ Coverage 98.31% 98.34% +0.02%
===========================================
Files 5 5
Lines 119 121 +2
Branches 4 5 +1
===========================================
+ Hits 117 119 +2
Misses 2 2
Continue to review full report at Codecov.
|
http_stubs/views.py
Outdated
| response[header_name] = header_value | ||
| return response | ||
|
|
||
| def remove_empty_headers(self, headers: Dict) -> Dict: |
There was a problem hiding this comment.
Maybe we should strive to use more accurate type annotations:
Dict[str, str] -> Dict[str, str]
http_stubs/tests/tests.py
Outdated
| :param client: http client fixture | ||
| """ | ||
| http_stub_factory(method=HTTPMethod.GET.name) | ||
| client.get('/default_path/') |
There was a problem hiding this comment.
Could you please move this string ('/default_path/') to a separate variable and use wherever it should be used
http_stubs/tests/tests.py
Outdated
| http_stub_factory(method=HTTPMethod.GET.name) | ||
| client.get('/default_path/') | ||
| log = LogEntry.objects.last() | ||
| assert log.headers == {} # noqa:WPS520 |
There was a problem hiding this comment.
| assert log.headers == {} # noqa:WPS520 | |
| assert bool(log.headers) is False |
I think, it would be better this way
|
Kudos, SonarCloud Quality Gate passed!
|
| http_stub_factory(method=HTTPMethod.GET.name) | ||
| client.get(self.path) | ||
| log = LogEntry.objects.last() | ||
| assert bool(log.headers) is False |
There was a problem hiding this comment.
Nitpicking, but:
| assert bool(log.headers) is False | |
| assert not bool(log.headers) |
| response[header_name] = header_value | ||
| return response | ||
|
|
||
| def remove_empty_headers(self, headers: Dict[str, str]) -> Dict[str, str]: |
There was a problem hiding this comment.
Just asking: can't be empty headers significant? E.g. indicate there's something wrong on the sending side?
3 participants
closes #47