Read cd stream, even for non-compliant non-bcd drives.#2
Open
jp-sarte wants to merge 1 commit intoUltraFuzzy:cd-pregap-detectionfrom
Open
Read cd stream, even for non-compliant non-bcd drives.#2jp-sarte wants to merge 1 commit intoUltraFuzzy:cd-pregap-detectionfrom
jp-sarte wants to merge 1 commit intoUltraFuzzy:cd-pregap-detectionfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
read_audio_subq_sector_with_retriesfunction with non-bcd drives. We should only need to re-rip the CD IF we're BCD and at least one read has returnedDRIVER_OP_ERROR, since this snippet otherwise will convert non-bcd to bcd.