Validate all macros in general context #1468
Merged
+46
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, macros were only validated in their binding site contexts, meaning macros that weren't bound to any key were never validated. Now Macros_ValidateAllMacros() also loops through all macros and validates them with argumentOffset=0 (general context). Commands containing "macroArg" are skipped during general context validation since they require binding-specific arguments. Added StrContains() utility function to str_utils for substring search. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
macroArgare skipped during general context validation since they require binding-specific argumentsStrContains()utility function to str_utils for substring searchTest plan
validateMacroscommand and verify unbound macros are now validatedmacroArgdon't produce false errors when validated in general context🤖 Generated with Claude Code