Skip to content

Conversation

@bryanfoley
Copy link
Contributor

@bryanfoley bryanfoley commented Oct 30, 2025

Description

With this PR, if a printer has the BOM number 109*, then it is an NGP printer and uses a large Colorado like screen, except it is not an inverted screen like the production printers.

So we use a different dts for machines with BOM's 109* which is very similar to the ulticontroller4.0-lvds-1024x600.dts, just the inversion of the x and y is removed.

How has this been tested

Installed this um-kernel package on NGP proto, after install teh touch response of the screen is correct.

Ready for Review Checklist

To help with deciding if this PR is RFR, use this checklist.

The author confirms that:

  • the author has self-reviewed this work and is highly confident about the quality
  • this work satisfies all acceptance criteria that are stated in the linked ticket
  • this work has been tested on all product families and the process and results are documented in the above section
  • The description above is concise yet complete
  • the reviewer has been offered a walkthrough (if needed)
  • the code is cleaned from any rubbish (e.g. meaningless comments, log-spamming, etc...)
  • remaining #TODO comments mention a Jira ticket number
  • all CI checks are passing
  • all commits are (re)structured to be meaningful and clearly arranged, and all are prepended with the ticket number for traceability

With this PR, if a printer has the BOM number 109*, then it is an NGP
printer and uses a large Colorado like screen, except it is not an
inverted screen like the production printers.

So we use a different dts for machines with BOM's 109* which is very
similar to the ulticontroller4.0-lvds-1024x600.dts, just the inversion
of the x and y is removed.
Copy link
Member

@robinmdh robinmdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however please note that I can't actually test this, as I don't have an NG printer to test on.

With this commit we reduce the contents of this file so that it only
removes the touch screen inversion.
@bryanfoley bryanfoley merged commit b9cf174 into master/imx8 Oct 31, 2025
4 checks passed
@bryanfoley bryanfoley changed the title [CES-3322] Set NGP Proto screens to the correct touch orientation [CES-3323] Set NGP Proto screens to the correct touch orientation Oct 31, 2025
@bryanfoley bryanfoley deleted the CES-3322-invert-NGP-screens branch October 31, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants