Skip to content

Conversation

@bryanfoley
Copy link
Contributor

@bryanfoley bryanfoley commented Sep 25, 2025

Description

We do not need this check here.

How has this been tested

  • The CI pipeline is passing again

Ready for Review Checklist

To help with deciding if this PR is RFR, use this checklist.

The author confirms that:

  • the author has self-reviewed this work and is highly confident about the quality
  • this work satisfies all acceptance criteria that are stated in the linked ticket
  • this work has been tested on all product families and the process and results are documented in the above section
  • The description above is concise yet complete
  • the reviewer has been offered a walkthrough (if needed)
  • the code is cleaned from any rubbish (e.g. meaningless comments, log-spamming, etc...)
  • remaining #TODO comments mention a Jira ticket number
  • all CI checks are passing
  • all commits are (re)structured to be meaningful and clearly arranged, and all are prepended with the ticket number for traceability

robinmdh
robinmdh previously approved these changes Sep 25, 2025
alexborro
alexborro previously approved these changes Sep 25, 2025
@bryanfoley bryanfoley dismissed stale reviews from alexborro and robinmdh via cd47d4c September 25, 2025 12:09
@bryanfoley bryanfoley force-pushed the CES-3333-fix-failing-shellcheck branch from 97d5413 to cd47d4c Compare September 25, 2025 12:09
We do not need this check here.
@bryanfoley bryanfoley force-pushed the CES-3333-fix-failing-shellcheck branch from cd47d4c to 73a899a Compare September 25, 2025 12:38
@bryanfoley bryanfoley merged commit 2c2bb10 into master/imx8 Sep 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants