Skip to content

[CURA-12675] Don't need this workaround anymore. #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HellAholic merged 1 commit into from
Aug 12, 2025
Merged

[CURA-12675] Don't need this workaround anymore. #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions .github/workflows/cura-installer-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,19 +113,6 @@ jobs:
& signtool sign /v /fd sha256 /tr http://timestamp.sectigo.com /td sha256 /f C:\actions-runner\code_sign.cer /csp "eToken Base Cryptographic Provider" /kc ${{ secrets.WIN_TOKEN_CONTAINER }} "UltiMaker-Cura.exe"
timeout-minutes: 2

- name: Workaround (need exact version of msvc redistributables)
run: |
$MSDIR="C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Redist/MSVC"
if ( (dir -Exclude "v*" $MSDIR).Count -ne 1 ) { throw "(!!!) MULTIPLE MSVC VERSIONS IN '$MSDIR' -- NEED EXACTLY 1 TO SELECT A REDISTRIBUTABLE (!!!)" }
$MSDIR_R=(dir -Exclude "v*" $MSDIR)[0].FullName
$MSDIR_DLLS=(dir $MSDIR_R/x64/Microsoft.VC*.CRT)[0].FullName
copy $MSDIR_DLLS/concrt140.dll dist/UltiMaker-Cura/.
copy $MSDIR_DLLS/msvcp140.dll dist/UltiMaker-Cura/.
copy $MSDIR_DLLS/msvcp140_1.dll dist/UltiMaker-Cura/.
copy $MSDIR_DLLS/msvcp140_2.dll dist/UltiMaker-Cura/.
copy $MSDIR_DLLS/vcruntime140.dll dist/UltiMaker-Cura/.
copy $MSDIR_DLLS/vcruntime140_1.dll dist/UltiMaker-Cura/.

- name: Workaround (some libs linking against python3 instead of python312)
run: |
copy Cura-workflows/python_dll_workaround/* dist/UltiMaker-Cura/.
Expand Down