Skip to content

Allow all browsers for record except mobile ones | #38521 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sschoorens merged 1 commit into from
Aug 27, 2025
Merged

Allow all browsers for record except mobile ones | #38521 #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/jsu.min.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/jsu.min.mjs
View file
Open in desktop

Large diffs are not rendered by default.

11 changes: 2 additions & 9 deletions src/jsu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,17 +513,10 @@ export default class JavaScriptUtilities {
this.browserVersion = version;
}
isRecordingAvailable () {
const isFirefoxCompat = this.browserName === 'firefox' && this.browserVersion >= 45;
const isChromeCompat = (this.browserName === 'chrome' || this.browserName === 'chromium') && this.browserVersion >= 57;
const isSafariCompat = this.browserName === 'safari' && this.browserVersion >= 16;
const isEdgeCompat = this.browserName === 'edge' && this.browserVersion >= 79;
return isFirefoxCompat || isChromeCompat || isEdgeCompat || isSafariCompat;
return this.browserName === 'safari' ? !this.isMobile && this.browserVersion >= 16 : !this.isMobile;
}
isLivestreamingAvailable () {
const isChromeCompat = (this.browserName === 'chrome' || this.browserName === 'chromium') && this.browserVersion >= 57;
const isEdgeCompat = this.browserName === 'edge' && this.browserVersion >= 79;
const isSafariCompat = this.browserName === 'safari' && this.browserVersion >= 16;
return isChromeCompat || isEdgeCompat || isSafariCompat;
return this.isRecordingAvailable() && this.browserName !== 'firefox';
}
useLang (lang) {
this._currentLang = lang;
Expand Down
41 changes: 32 additions & 9 deletions tests/test_jsu.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,21 +146,44 @@ describe('JSU', () => {
});
it('should handle isRecordingAvailable()', () => {
const data = [
['safari', '6', false],
['firefox', '30', false],
['chrome', '30', false],
['chromium', '30', false],
['edge', '30', false],
['firefox', '100', true],
['chrome', '100', true],
['edge', '100', true]
['safari', '15', true, false],
['firefox', '100', true, false],
['chrome', '100', true, false],
['edge', '100', true, false],
['safari', '16', true, false],
['safari', '15', false, false],
['firefox', '100', false, true],
['chrome', '100', false, true],
['edge', '100', false, true],
['safari', '16', false, true]
];
for (const [browserName, browserVersion, result] of data) {
for (const [browserName, browserVersion, isMobile, result] of data) {
jsu.browserName = browserName;
jsu.browserVersion = browserVersion;
jsu.isMobile = isMobile;
assert(jsu.isRecordingAvailable() === result, `${browserName}@${browserVersion} isRecordingAvailable ${jsu.isRecordingAvailable()}`);
}
});
it('should handle isLivestreamingAvailable()', () => {
const data = [
['safari', '15', true, false],
['firefox', '100', true, false],
['chrome', '100', true, false],
['edge', '100', true, false],
['safari', '16', true, false],
['safari', '15', false, false],
['firefox', '100', false, false],
['chrome', '100', false, true],
['edge', '100', false, true],
['safari', '16', false, true]
];
for (const [browserName, browserVersion, isMobile, result] of data) {
jsu.browserName = browserName;
jsu.browserVersion = browserVersion;
jsu.isMobile = isMobile;
assert(jsu.isLivestreamingAvailable() === result, `${browserName}@${browserVersion} isLivestreamingAvailable ${jsu.isLivestreamingAvailable()}`);
}
});
it('should handle translations', () => {
const translations = {
'fr': {
Expand Down