Misc/initialize ido pool by sjillen · Pull Request #1 · UXDProtocol/multisig-ui

sjillen · 2021-11-05T19:04:58Z

Need to check that the accounts arrays are correct.
At the moment we are creating the required accounts live (they are just logged into the console).
Maybe we prefer to initialize them manually beforehand and input them via the form?

- for initialize_pool - for withdraw_pool_usdc

vercel · 2021-11-05T19:05:01Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/soteriateam/uxd-multisig-ui/A1iVC3Ukq5jLwyaZ12XVVKEAeRUJ
✅ Preview: https://uxd-multisig-ui-git-misc-initialize-ido-pool-soteriateam.vercel.app

acamill · 2021-11-05T19:18:56Z

I think we want to create them

acamill · 2021-11-05T19:30:28Z

Maybe can do the redeem

sjillen · 2021-11-06T19:55:02Z

So far it seems that our variables are now correctly instantiated but we are still an issue right when we are sending the transaction.

It looks like somewhere inside createTransaction, is not instantiated as a PublicKey (probably just a string).
I modified how we encode the data for the transaction with some hint from the guys from anchor.

acamill · 2021-11-06T16:12:09Z

src/components/Multisig.tsx

+            // pool_signer -- this is the multisig PDA : 35F3GaWyShU5N5ygYAFWDw6bGVNHnAHSe8RKzqRD2RkT
+            //? While testing we used to use a derivation from the uxp mint for creating this account
+            {
+                pubkey: multisigPDA,


shouldnt it be changed back to what you were doing before with derivation?

acamill · 2021-11-06T23:29:25Z

src/components/Multisig.tsx


 export function MultisigInstance({ multisig }: { multisig: PublicKey }) {
-  const { multisigClient } = useWallet();
+  const { multisigClient, uxdClient } = useWallet();


acamill · 2021-11-06T23:31:46Z

src/components/Multisig.tsx

+const multisigPDA = new PublicKey("35F3GaWyShU5N5ygYAFWDw6bGVNHnAHSe8RKzqRD2RkT"); //? Can we actually get that from the multisigClient?
+const uxpMint = new PublicKey('MNDEFzGvMt87ueuHvVU9VcTqsAP5b3fTGPsHuuPA5ey');//new PublicKey("UXPhBoR3qG4UCiGNJfV7MqhHyFqKN68g45GoYvAeL2M");
+const usdcMint = new PublicKey("2wmVCSfPxGPjrnMMn7rchp4uaeoTqN39mXFC2zhPdri9"); //* That"s the mainnet one
+const uxpMultisigTokenAccount = new PublicKey("GJgkVjjsYZeY2RLKcd7346A2dreykurTxkeNw6ysVQkc"); //! We should be able to get it from chain


This one needs to be the MNDE token account for the test, as the TMP change line 847

Comment and use 4BWt4xZ5okZRfd3KtXujjHJaHCLfjekJPLMdUzhFmSQW instead

acamill · 2021-11-06T23:32:18Z

src/components/Multisig.tsx

+const usdcMint = new PublicKey("2wmVCSfPxGPjrnMMn7rchp4uaeoTqN39mXFC2zhPdri9"); //* That"s the mainnet one
+const uxpMultisigTokenAccount = new PublicKey("GJgkVjjsYZeY2RLKcd7346A2dreykurTxkeNw6ysVQkc"); //! We should be able to get it from chain
+
+function WithdrawUSDCPoolListItemDetails({


Should just be withdrawIdoPool, code could stay generic and not use any mention of specific mint. For a later refactor I guess, let's just make this work

acamill · 2021-11-06T23:35:50Z

src/components/Multisig.tsx

+           // We use the uxp mint address as the seed, could use something else though.
+           const [_poolSigner] = await anchor.web3.PublicKey.findProgramAddress(
+            [uxpMint.toBuffer()],
+            UXDIDOProgramAdress


same comments about genericity (UXD Ido and uxp mint) but w/e

acamill · 2021-11-06T23:46:28Z

src/components/Multisig.tsx

+            },
+        ];
+        const transaction = new Keypair();
+        const txSize = 1000; // todo


TX size might end up being bigger than 1000, if you still have your issue please double check this, shouldn't be though, but keep in mind

looks ok at least until execution

acamill · 2021-11-07T00:04:40Z

src/components/Multisig.tsx

+            multisigClient.programId,
+            accounts,
+            data,
+            {


^ So you call the multisig program createTransaction, sending the multisigProgramID, the accounts this specific transaction expect, and the data serialized as expected by this transaction.

Below you should be doing the same but for the "nested" instruction.

as said on slack earlier. You pass the multisig programID but that should be the IDOprogramId. The account should be the account the Initialize account expect. And you should probably by passing some data too.

Remember to zoom out, and this "what is this instruction actually doing"

I'm not sure about where the data should be cause I don't have the IDE open, but please read the function signature of multisig. createTransaction and determine wether it should be passed where it is now or in the nesting

also should have an result checking for the success to be dsplayed. non essential for now

That one was quite the trick. See code update for how it is supposed to work

yeah will do later, I'm planning maybe a small refactor tonight for more clarity and separating components into their own file, easier to navigate

acamill · 2021-11-07T00:07:40Z

src/components/Multisig.tsx

+              {
+                  pubkey: poolSigner,
+                  isWritable: false,
+                  isSigner: true,


Not a signer. Please check IDL

acamill · 2021-11-07T00:08:41Z

src/components/Multisig.tsx

+              },
+              // uxp_mint -- This is UXP UXPhBoR3qG4UCiGNJfV7MqhHyFqKN68g45GoYvAeL2M token () https://solscan.io/token/UXPhBoR3qG4UCiGNJfV7MqhHyFqKN68g45GoYvAeL2M ()
+              {
+                  pubkey: new PublicKey("UXPhBoR3qG4UCiGNJfV7MqhHyFqKN68g45GoYvAeL2M"),


Please no hardcoded variable. How do we keep up with this. I wanna rewrite it already, feel like so easy to get mixed up

also same as above, please prepare variable with explicit names before and assign the value in one place, there here use said variable for explicitness so we can reason

acamill · 2021-11-07T00:10:04Z

src/components/Multisig.tsx

+            uxpMint,
+            poolUxp,
+            poolUsdc,
+            creatorUxp: uxpMultisigTokenAccount,


multisigUxpTokenAccount

…gramId during tx signature

…instructions array

acamill · 2021-11-13T19:18:50Z

@ThomasProust Not sure what's the state of this PR. Can we maybe close it is it's stale/unused, and add the close to another one/remove/hide depending on what's available. I don't think we have the time not to make a proper tool

acamill and others added 6 commits November 5, 2021 11:48

What I think should be done

a168021

- for initialize_pool - for withdraw_pool_usdc

Deeper

f50665f

more details

b1ee719

More details

8d1b00d

more details

0ba413d

complete initialize IDO and withdraw USDC IDO transactions

03ddd59

sjillen requested a review from acamill November 5, 2021 19:04

vercel bot deployed to Preview November 6, 2021 14:40 View deployment

acamill assigned sjillen Nov 6, 2021

acamill added the enhancement New feature or request label Nov 6, 2021

add poolSigner, accounts generated on the fly

2a7f27d

sjillen force-pushed the misc/initialize-ido-pool branch from 81b064d to 2a7f27d Compare November 6, 2021 15:10

vercel bot deployed to Preview November 6, 2021 15:10 View deployment

createMint and token are instructions injected in main call

35bef4d

vercel bot deployed to Preview November 6, 2021 16:09 View deployment

use poolSigner from uxpmint derivation in withdraw usdc

13e77b6

vercel bot deployed to Preview November 6, 2021 16:15 View deployment

use Marinade instead of uxp for testing

82ccee9

vercel bot deployed to Preview November 6, 2021 16:24 View deployment

encode data using uxd anchor program

51b3dde

vercel bot had a problem deploying to Preview November 6, 2021 17:12 Failure

add UXD ido idl

31e14ab

vercel bot deployed to Preview November 6, 2021 17:14 View deployment

wip fix initialize IDO tx

b83124c

vercel bot deployed to Preview November 6, 2021 19:46 View deployment

acamill reviewed Nov 7, 2021

View reviewed changes

still wip, encoding seems fine, small reorg, issue with undefined pro…

38000a0

…gramId during tx signature

vercel bot deployed to Preview November 7, 2021 02:35 View deployment

encode itxs related to initializeIdo into data instead of passing in …

5368abe

…instructions array

vercel bot deployed to Preview November 7, 2021 05:14 View deployment

rework withdrawIdoPool

59e97a7

vercel bot deployed to Preview November 7, 2021 06:55 View deployment

small refacto for more clarity

e0e6d22

vercel bot deployed to Preview November 7, 2021 07:15 View deployment

sjillen added 3 commits November 7, 2021 17:47

add wallet in signers

6aeb0cb

remove wallet from signers

5c7e868

remove signers for top tx

87dee9b

vercel bot deployed to Preview November 7, 2021 09:11 View deployment

vercel bot deployed to Preview November 7, 2021 09:47 View deployment

vercel bot deployed to Preview November 7, 2021 09:52 View deployment

Conversation

sjillen commented Nov 5, 2021

Uh oh!

vercel bot commented Nov 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

acamill commented Nov 5, 2021

Uh oh!

acamill commented Nov 5, 2021

Uh oh!

sjillen commented Nov 6, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

acamill commented Nov 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel bot commented Nov 5, 2021 •

edited

Loading