Open
Conversation
Migrate to UXD client 3.0.0
…nto solana-labs-main
…nto solana-labs-main
…nto solana-labs-main
…nto solana-labs-main
…nto solana-labs-main
* chore(deps): remove cardinal, fix token-registry version * fix from comments, update yarn.lock, remove package.lock
* Implement set error flag
* Mercurial new SDK version * Add compute budget program
* Implement credix deposit/withdraw
Support mercurial (uxd-client v5.0.0)
* change RPC * remove billowing RPC
Handle identity depository
Fix/identity depository config
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sjillen
approved these changes
Feb 15, 2023
Comment on lines
+20
to
+25
| case 2 as any /*VoteKind.Abstain*/: { | ||
| return false; | ||
| } | ||
| case 3 as any /*VoteKind.Veto*/: { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
how come voting was working before without that??
Author
There was a problem hiding this comment.
it break the app when you load a governance that had experienced one of the vote. Got it to break on FakeDAO
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.