Skip to content

Automatic installation of dependencies and package data #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ldgibson wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Automatic installation of dependencies and package data #52

ldgibson wants to merge 2 commits into from

Conversation

@ldgibson
Copy link
Contributor

@ldgibson ldgibson commented Dec 10, 2021 •
edited
Loading

This PR included changes to setup.py which enables the automatic installation of dependencies and also the package data containing periodic table information when the package is installed via pip install. This PR addresses #33 and #34 .

@ldgibson ldgibson requested a review from lemmoi December 10, 2021 23:36
lemmoi
lemmoi requested changes Dec 11, 2021
View reviewed changes
Copy link
Contributor

@lemmoi lemmoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also remove the requirements.txt from the unittest CI here - just to make sure it builds without it.

The integration tests will still need it since it installs a specific version of mdtraj to avoid needing build tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lemmoi lemmoi lemmoi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ldgibson @lemmoi