Skip to content

Conversation

@stiber
Copy link
Contributor

@stiber stiber commented Aug 7, 2025

Release for summer 2025, ready for final checks and release creation.

Testing (Mandatory for all changes)

  • GPU Test: test-medium-connected.xml Passed
  • GPU Test: test-large-long.xml Passed

whiteja2 and others added 30 commits November 17, 2023 12:39
Update development to include EventBuffer unit tests
…-test

[ISSUE-703] Add Serialization tests for CPU neural simulations
…bular-view

Issue 518 visualizer tabular view
Changed file name and pasted in new top-level diagram.
[hotfix-issue-756] Apply hotfixes to SharedDevelopment
Also tweaked the old details about cherry picking into master, so the reader can understand why we're doing this complicated approach.
…l-test

[ISSUE 754] Add serial-File-Access-Test Removed During Serialization Test Update
@stiber stiber self-assigned this Aug 7, 2025
@NicolasJPosey
Copy link
Contributor

@stiber I was seeing some compile issues on a branch I just made off of SharedDevelopment when compiling for the GPU so I checked this branch out to confirm if it was something I did or not. I got the same errors. They are as follows:

  1. When compiling, an error is detected in ConnGrowth_d.cpp. We are calling layout.vertexTypeMap_.data(). The map was recently changed from a vector to a RecordableVector but RecordableVector doesn't implement std::vector.data(). I locally tried implementing T *data() in RecordableVector and this resolved the issue. We are using it in a HostToDevice copy so maybe const T *data() is the better one to implement.
  2. After resolving 1, I get a error in serialFirstHalfTest (I think it's during the linkage step). It says that there is an undefined reference to Connections911::registerHistoryVariables(). I don't get this error often enough to know what exactly is needed to resolve it.

@NicolasJPosey
Copy link
Contributor

NicolasJPosey commented Aug 10, 2025

@stiber I figured out 2. The registerHistoryVariables implementation was inside of a #if !(USE_GPU) so the linker couldn't find it. I will create a branch off of SharedDevelopment with these changes and we can pull them into the release branch when we are happy with the proposed fixes.

In addition, the GPU regression tests don't pass. It looks like their results files were not updated; they are missing the x_location, y_location, and vertexTypeMap outputs. I will include those in the PR.

NicolasJPosey and others added 2 commits August 11, 2025 14:52
* Implement data member for use by ConnGrowth_d

* Move registerHistoryVariables so it can be linked for GPU

* Add new output from Recorder updates to GPU regression results
@stiber stiber requested a review from NicolasJPosey September 9, 2025 16:35
@stiber stiber merged commit b1f5bd3 into master Sep 9, 2025
2 of 3 checks passed
@stiber stiber deleted the release-v-1.1 branch September 9, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.