Device Vector added and Integrated with Neuro Vertices #850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avikantw
force-pushed
the
AvikantDevelopment
branch
3 times, most recently
from
78efdeb to
d0c2b42
Compare
stiber
requested changes
May 16, 2025
Contributor
stiber
left a comment
stiber
left a comment
There was a problem hiding this comment.
Mostly commenting. Some questions.
Avikantw
force-pushed
the
AvikantDevelopment
branch
from
d0c2b42 to
32af917
Compare
Avikantw
force-pushed
the
AvikantDevelopment
branch
4 times, most recently
from
013e6c8 to
4ac86a4
Compare
Avikantw
force-pushed
the
AvikantDevelopment
branch
from
4ac86a4 to
d72c9cb
Compare
stiber
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DeviceVector.h is added in the Utils and integrated with neural vertex classes. It is conditionally compiled on the basis of CUDACC macros defined by nvcc.
Structures are basically empty now except it still holds only event buffer for the device code.
Each kernel takes explicit parameter.
Units tests are also added which tests both CPU and GPU functionality for device vector.
Checklist (Mandatory for new features)
Testing (Mandatory for all changes)
test-medium-connected.xmlPassedtest-large-long.xmlPassed