This repository was archived by the owner on Nov 13, 2025. It is now read-only.
showing annotated images for detect target message bug fix #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xierumeng
reviewed
Nov 30, 2024
Comment on lines
32
to
33
| Returns: | ||
| Success, detect target object. |
Collaborator
There was a problem hiding this comment.
Return: Success, detect target object.
| show_annotations, | ||
| save_name, | ||
| ) | ||
|
|
Comment on lines
+49
to
+51
| if self.__device != "cpu" and not torch.cuda.is_available(): | ||
| self.__local_logger.warning("CUDA not available. Falling back to CPU.") | ||
| self.__device = "cpu" |
Collaborator
There was a problem hiding this comment.
Add empty line above this line.
* Implement brightspot detection * Fix detections * Add to factory method * Add multiple testing images * Separate tests into detections and no detections * Fix minor issues * Fix comments * Fix image naming * Add check for no detections * Fix constant ordering
* integrated camera_factory in video_input * added missing parameters * removed cluster estimation test file * accommodate video input for new camera factory and logger changes in common * refactor for moving camera config classes into each camera module * add comments and change empty to string to a valid iamge prefix * Fix comments * refactor video_input save_prefix to image_name, for proper use with logger.save_image * bug fix for video_input integration tests --------- Co-authored-by: Maxwell Lou <maxlou2005@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed annotation bug so that opencv can display images in a GUI for detect_target.