Skip to content
This repository was archived by the owner on Nov 13, 2025. It is now read-only.

Conversation

@wdan31
Copy link
Contributor

@wdan31 wdan31 commented Nov 3, 2024

The logs describe time it took to process images and when images were processed.

Copy link
Member

@maxlou05 maxlou05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please update the common submodule (easiest way is to just run setup_project.ps1 or source setup_project.sh)


end_time = time.time()
self.__logger.info(
f"{time.localtime()}: Target detection took {round(end_time - start_time, 3)} seconds"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For time, it's fine to just use time.time() (logger automatically puts a timestamp with a proper format like hh:mm:ss), and there's no need to round it since we would rather have more precision. (these tasks usually take much less than 1 second, so more precision is required)

@wdan31 wdan31 closed this Nov 3, 2024
@wdan31 wdan31 deleted the detect-target-worker branch November 3, 2024 18:14
@wdan31 wdan31 restored the detect-target-worker branch November 7, 2024 22:17
@wdan31 wdan31 reopened this Nov 7, 2024
Copy link
Member

@maxlou05 maxlou05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@wdan31 wdan31 merged commit cd9e7cc into main Nov 15, 2024
1 check passed
@wdan31 wdan31 deleted the detect-target-worker branch November 15, 2024 23:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants