Ee

[magnustveit1]

No description provided.

[Copilot]

Pull request overview

This PR appears to extend the project’s data-acquisition/analysis tooling by (1) switching SNOTEL retrieval in getData.py to requests, and (2) adding an Earth Engine (EE) / Landsat NDSI workflow (new notebook + a helper function), alongside updated analysis notebooks.

Changes:

• Update getSNOTELData to fetch CSV via requests instead of urllib3.
• Add a Landsat 8 NDSI time series helper (get_Landsat_NDSI) and introduce a new EE_Exercise.ipynb notebook.
• Update existing notebooks’ outputs/metadata (including captured errors/warnings).

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated 12 comments.

File	Description
supporting_scripts/getData.py	Switch SNOTEL download to requests; add a Landsat NDSI helper using Earth Engine.
HydroDF_Analysis.ipynb	Notebook output/metadata updates; now includes a captured FileNotFoundError.
EE_Exercise.ipynb	New EE exercise notebook combining basin geometry, SNOTEL, and Landsat NDSI workflows.
CatchmentAttributes_nhdplus.ipynb	Notebook output churn (environment-specific warning paths).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

stream_df is used here but is never defined anywhere in this notebook (the only reference is this line), so this cell will fail with NameError. Define stream_df earlier (e.g., by fetching NWIS streamflow for usgs_gage_id) or change this to use the correct variable name.

Suggested change

	"stream = stream_df.copy()\n",
	"stream = stream_df.copy() if \"stream_df\" in globals() else pd.DataFrame()\n",

[Copilot]

Spelling: "Allign" -> "Align".

Suggested change

	"Clean and Allign"
	"Clean and Align"

[Copilot]

requests.get(...) is used here but requests is never imported in this module, which will raise NameError at runtime. Add an explicit import requests (and ensure it is included in the project environment/requirements).

[Copilot]

Calling ee.Authenticate() / ee.Initialize() inside this helper will repeatedly trigger interactive auth and makes the function hard to use in non-interactive runs (CI, scripts, batch jobs). Prefer initializing EE once at program entry (or guard with if not ee.data._initialized: / similar) and keep this helper purely computational.

Suggested change

	ee.Authenticate()
	ee.Initialize()
	if not ee.data._initialized:
	try:
	ee.Initialize()
	except Exception:
	ee.Authenticate()
	ee.Initialize()

[Copilot]

This notebook is currently committed with a captured FileNotFoundError output, which makes the checked-in notebook look broken/non-reproducible. Please either fix the path so the notebook runs end-to-end from a clean checkout, or clear cell outputs/errors before committing.

[Copilot]

from urllib import response is unused here and also collides with the local response = ... variables used below. Please remove this import to avoid confusion/shadowing.

Suggested change

from urllib import response

[Copilot]

This implementation pulls n and then loops client-side, calling .getInfo() for every image (and again for the date), which can be very slow and can hit Earth Engine rate/timeout limits for longer date ranges. Consider doing the reduction server-side (e.g., col.map(...) to set mean NDSI + date properties) and then fetching/exporting the resulting FeatureCollection in one call.

[Copilot]

This change updates only an environment-specific warning output path (e.g., /uufs/.../site-packages/...). Consider clearing notebook outputs before committing so diffs don’t churn due to local execution environment paths.

[Copilot]

This notebook is committed with populated execution_counts and captured outputs (including environment-specific warnings/paths). Please clear outputs and set execution_count to null before committing to avoid noisy diffs and leaking local environment details.

[Copilot]

This cell appears to treat the USGS gage id (09330000) as a SNOTEL station id ({SiteID}:{StateAbb}:SNTL in the URL). That’s likely why the download is timing out/failing. Please use an actual SNOTEL station id (or add a step that finds the nearest SNOTEL station to the basin/gage) and keep the USGS gage id separate.

Suggested change

	"SiteName = \"FREMONT RIVER NEAR BICKNELL\"\n",
	"SiteID = \"09330000\"\n",
	"# USGS gage identifier for Fremont River near Bicknell\n",
	"USGS_GAGE_ID = \"09330000\"\n",
	"\n",
	"# SNOTEL station information (separate from the USGS gage ID)\n",
	"SiteName = \"BOULDER MOUNTAIN\"\n",
	"SiteID = \"822\" # SNOTEL SiteID for BOULDER MOUNTAIN, UT\n",