Add changes to activate cron job that deletes old applications 7 days after role appointment is done and saved #795
Conversation
…ys after role appointment is done and saved
ludvigalden
requested review from
ludvigalden
and removed request for
robindymer
ludvigalden
left a comment
ludvigalden
left a comment
There was a problem hiding this comment.
Any idea why the CRON-job might not be invoked by django-kronos, @anandmatt?
| ).exclude( | ||
| status='appointed' | ||
| ).filter( | ||
| status='turned_down' |
There was a problem hiding this comment.
The change to remove only turned_down applications is good, because currently, it expects that applications are appointed within a week of the application end date, which is not always the case. The status is set to turned_down only when they have been appointed.
| if not created: | ||
| appl.status = 'appointed' | ||
| appl.save() | ||
| cron.remove_old_applications() |
There was a problem hiding this comment.
So a CRON-job is not supposed to be invoked manually, by definition. Unless there is some issue with django-kronos not installing the CRON-jobs correctly, I don't think there is any problem in terms of remove_old_applications not being called. The crontab on the server looks fine. So I think the change to invoke it without django-kronos should be removed.
Description of the Change
Cron job that was supposed to delete old applications had no implementation. Changes done to call this cron job to delete old applications that were turned down, 7 days after a role has been appointed and saved.
Applicable Issues
Fixes issue #786
feature