Skip to content

Conversation

@mhweber
Copy link
Collaborator

@mhweber mhweber commented Nov 13, 2025

  • Handles a web service being down in testing using testthat::skip_on_cran()
  • Converts most vignettes to articles and adds one new Start Here vignette

jbousquin and others added 27 commits September 23, 2025 14:31
* Create coverage.yaml

Init commit

* Update coverage.yaml

Make sure the report name is specified

* Update coverage.yaml

Try to get report from ./cobertura.xml

* Update coverage.yaml

Not there... but try being specific

* Update coverage.yaml

In case . is somewhere else be specific about where to write

* Update coverage.yaml

Simplify

* Update coverage.yaml

Point action to correct coverage report file

* Update coverage.yaml

Attempt permissions route to post comment vs PAT
* updated params metrics function and added dontrun for examples

* test passing with updates to sc and lc params functions and new sc and lc get_metric_names functions
Merge branch 'develop' of https://github.com/USEPA/StreamCatTools into develop
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
Merge branch 'master' into develop

# Conflicts:
#	DESCRIPTION
#	NEWS.md
Merge branch 'master' into develop

# Conflicts:
#	_pkgdown.yml
#	docs/404.html
#	docs/LICENSE.html
#	docs/articles/Applications.html
#	docs/articles/Introduction.html
#	docs/articles/LakeCat.html
#	docs/articles/index.html
#	docs/authors.html
#	docs/index.html
#	docs/news/index.html
#	docs/pkgdown.yml
#	docs/reference/index.html
#	docs/reference/lc_fullname.html
#	docs/reference/lc_get_comid.html
#	docs/reference/lc_get_data.html
#	docs/reference/lc_get_metric_names.html
#	docs/reference/lc_get_params.html
#	docs/reference/lc_nlcd.html
#	docs/reference/sc_fullname.html
#	docs/reference/sc_get_comid.html
#	docs/reference/sc_get_data.html
#	docs/reference/sc_get_metric_names.html
#	docs/reference/sc_get_params.html
#	docs/reference/sc_nlcd.html
#	docs/search.json
@mhweber mhweber self-assigned this Nov 13, 2025
@mhweber mhweber added the bug Something isn't working label Nov 13, 2025
@mhweber mhweber merged commit 89a4279 into master Nov 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants