Metric categories #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
coverage-report
Minimum allowed coverage is Generated by 🐒 cobertura-action against e809298 |
mhweber
added a commit
that referenced
this pull request
Oct 8, 2025
* Develop (#78) * Create coverage.yaml Init commit * Update coverage.yaml Make sure the report name is specified * Update coverage.yaml Try to get report from ./cobertura.xml * Update coverage.yaml Not there... but try being specific * Update coverage.yaml In case . is somewhere else be specific about where to write * Update coverage.yaml Simplify * Update coverage.yaml Point action to correct coverage report file * Update coverage.yaml Attempt permissions route to post comment vs PAT * Trying Jeff's epar package to generate code cov badge * incrementing dev version * Metric categories (#79) * updated params metrics function and added dontrun for examples * test passing with updates to sc and lc params functions and new sc and lc get_metric_names functions * Updating version * changes to sc_get_params and lc_get_params * fix to allow passing vectors of metric, state, county, region to both sc_get_data and sc_get_data * remove global variables messages * couple more updates to get_params functions and adding Mike as contributor * updated documentation --------- Co-authored-by: Justin Bousquin <bousquin.justin@epa.gov> Co-authored-by: Michael Dumelle <Dumelle.Michael@epa.gov>
mhweber
added a commit
that referenced
this pull request
Oct 15, 2025
* Develop (#78) * Create coverage.yaml Init commit * Update coverage.yaml Make sure the report name is specified * Update coverage.yaml Try to get report from ./cobertura.xml * Update coverage.yaml Not there... but try being specific * Update coverage.yaml In case . is somewhere else be specific about where to write * Update coverage.yaml Simplify * Update coverage.yaml Point action to correct coverage report file * Update coverage.yaml Attempt permissions route to post comment vs PAT * Trying Jeff's epar package to generate code cov badge * incrementing dev version * Metric categories (#79) * updated params metrics function and added dontrun for examples * test passing with updates to sc and lc params functions and new sc and lc get_metric_names functions * Updating version * changes to sc_get_params and lc_get_params * fix to allow passing vectors of metric, state, county, region to both sc_get_data and sc_get_data * remove global variables messages * couple more updates to get_params functions and adding Mike as contributor * updated documentation * Increment develop branch * added try catch to functions to fail gracefully and fixed column separator in get_metric_names * added new get_metric_names example to Vignettes and last fixes to tryCatch in functions * document new functions * updated CRAN comments --------- Co-authored-by: Justin Bousquin <bousquin.justin@epa.gov> Co-authored-by: Michael Dumelle <Dumelle.Michael@epa.gov>
mhweber
added a commit
that referenced
this pull request
Nov 13, 2025
* Develop (#78) * Create coverage.yaml Init commit * Update coverage.yaml Make sure the report name is specified * Update coverage.yaml Try to get report from ./cobertura.xml * Update coverage.yaml Not there... but try being specific * Update coverage.yaml In case . is somewhere else be specific about where to write * Update coverage.yaml Simplify * Update coverage.yaml Point action to correct coverage report file * Update coverage.yaml Attempt permissions route to post comment vs PAT * Trying Jeff's epar package to generate code cov badge * incrementing dev version * Metric categories (#79) * updated params metrics function and added dontrun for examples * test passing with updates to sc and lc params functions and new sc and lc get_metric_names functions * Updating version * changes to sc_get_params and lc_get_params * fix to allow passing vectors of metric, state, county, region to both sc_get_data and sc_get_data * remove global variables messages * couple more updates to get_params functions and adding Mike as contributor * updated documentation * Increment develop branch * added try catch to functions to fail gracefully and fixed column separator in get_metric_names * added new get_metric_names example to Vignettes and last fixes to tryCatch in functions * document new functions * updated CRAN comments * Ordered vignettes in github pages * handling in vignettes for web service being down * updated CRAN comments * Updated NEWS and DESCRIPTION * updated CRAN comments * Switched most vignettes to articles * updated CRAN comments and NEWS --------- Co-authored-by: Justin Bousquin <bousquin.justin@epa.gov> Co-authored-by: Michael Dumelle <Dumelle.Michael@epa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new
sc_get_metric_namesandlc_get_metric_namesfunctions and enhances the existingsc_get_paramsandlc_get_paramsfunctions and addresses the enhancement asked for in #52 to make metrics more searchable