Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors Init to centralize JSON unmarshalling with error handling and introduces named constants for stability criteria keys.
- Extracted JSON parsing into a helper with error returns
- Added
log.Fatalfon curve initialization errors - Defined
WoodUnanchoredKey,WoodAnchoredKey, andMasonryConcreteBrickKeyas constants and refactored the stability map
Comments suppressed due to low confidence (1)
lifeloss/lifeloss.go:40
- The new helper
createLethalityCurveintroduces an error path that isn't covered by existing tests. Add unit tests for both successful and failing JSON inputs to verify its behavior.
createLethalityCurve := func(data []byte) (LethalityCurve, error) {
| } | ||
| high, err := createLethalityCurve(DefaultHighLethalityBytes) | ||
| if err != nil { | ||
| log.Fatalf("Failed to initialize high lethality curve: %v", err) |
There was a problem hiding this comment.
[nitpick] Calling log.Fatalf will terminate the entire application on JSON errors. Consider changing Init to return an error so callers can handle initialization failures more gracefully.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.