CDA-92: Fix to resolve TimeSeriesGroup DAO serializing AssignedTimeSeries nulls#1566
Merged
rma-rripken merged 2 commits intoUSACE:developfrom Feb 4, 2026
Merged
Conversation
…l attributes as strings. Includes integration test and serialization unit test. Resolves USACE#1564
rma-rripken
approved these changes
Feb 4, 2026
Collaborator
|
I did a search across the code base and couldn't find any other places were the same pattern was used so we shouldn't hit this error on any other DTO |
Collaborator
|
LocationGroups were built slightly differently so they shouldn't exhibit this either |
Contributor
|
So why did this bypass the "latest schema" check? at least without any explanation. Fast resolution is got, not if it risks breaking something else though. |
Collaborator
|
I bypassed the latest schema check b/c it has been broken. There are two failing IT tests, one in WaterSupplyAccounting and another in TimeSeriesFiltered that only fail in latest. They failed for me and Bryson both in our recent PR's. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix to resolve TimeSeriesGroup DAO serializing AssignedTimeSeries null attributes as strings.
Includes integration test and serialization unit test.
Resolves #1564