Open
Conversation
rma-rripken
approved these changes
Jan 26, 2026
Contributor
Author
|
Update the test code to handle the required docker environment with test-containers issue we had. While most of the update was just "correct import", it exposed that one test was using the wrong Junit assertion and thus behavior was not covered. Since the intent of this PR is just to update tomcat and then allow a settings change I've altered the behavior of the test itself so as not to risk a cascade of changes at this time. I may also decide that instead of a "prod" branch that whatever is correctly functional in -test is what it then prod - if that decision is made I will adjust the various branches and github actions accordingly. |
86a68eb to
9213438
Compare
rma-rripken
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Tomcat version in test and docker. dev/test already using this version.