Resolving issues identified from static analysis#1540
Merged
RyanM-RMA merged 7 commits intoUSACE:developfrom Jan 31, 2026
Merged
Resolving issues identified from static analysis#1540RyanM-RMA merged 7 commits intoUSACE:developfrom
RyanM-RMA merged 7 commits intoUSACE:developfrom
Conversation
…ented" JSON response across Controller classes (USACE#1365)
RyanM-RMA
force-pushed
the
bugfix/cda-68_resolving_static_analysis_issues
branch
from
58404ee to
d142d94
Compare
…ocumentation for unused query parameters.
…reamline `MetricRegistry` initialization, and standardize path parameter logging.
MikeNeilson
reviewed
Jan 30, 2026
rma-rripken
reviewed
Jan 30, 2026
cwms-data-api/src/main/java/cwms/cda/api/StandardTextController.java
Outdated
Show resolved
Hide resolved
rma-rripken
reviewed
Jan 30, 2026
rma-rripken
reviewed
Jan 30, 2026
cwms-data-api/src/main/java/cwms/cda/api/TimeSeriesFilteredController.java
Show resolved
Hide resolved
rma-rripken
requested changes
Jan 30, 2026
Collaborator
rma-rripken
left a comment
rma-rripken
left a comment
There was a problem hiding this comment.
Couple minor things I noticed.
Updated logic for OpenApiDocTest to find those and check for them. Added file line ref for debugging when a test fails for faster access to the class and method.
rma-rripken
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1475
This will include changes to resolve issues identified by the initial static analysis tests.