Conversation
…ting class until that can be fixed.
…odes directly/at the edge just before render
jbkolze
left a comment
jbkolze
left a comment
There was a problem hiding this comment.
Component looks good -- just a little docs stuff to clean up (mostly around the useDataStatusFile update).
| <Badge color="yellow" className="my-2"> | ||
| You must specify either dataStatusUrl or tsids or the table will have no | ||
| values! | ||
| </Badge> |
There was a problem hiding this comment.
Can remove dataStatusUrl here
| import Divider from "../../components/divider"; | ||
| import { Code } from "../../components/code"; | ||
| // import { DataStatus } from "@usace-watermanagement/groundwork-water" | ||
| import DataStatus from "../../../../../lib/components/data/summary/DataStatus"; |
There was a problem hiding this comment.
Think we need to import from @usace-watermanagement/groundwork-water rather than local
There was a problem hiding this comment.
Should probably add this page to the nav-links
There was a problem hiding this comment.
Also should probably throw in some quick docs for useDataStatusFile. Could see them either just being an addendum to the DataStatus page or on their own. Either way works.
| return <DataStatus | ||
| office="SWT" | ||
| tsids={[...tsids, ...fileTsids]} | ||
| dataStatusUrl={"/data/summary/swt.datastatus"} |
There was a problem hiding this comment.
Can remove the dataStatusUrl line
| {!filePending && fileError ? <div>Failed to load TSID data status file! {fileError?.message}</div> : <DataStatus | ||
| office="SWT" | ||
| tsids={["KEYS.Elev.Inst.1Hour.0.Ccp-Rev", ...fileTsids]} | ||
| dataStatusUrl={"/data/summary/swt.datastatus"} |
There was a problem hiding this comment.
dataStatusUrl here can be removed as well
| { | ||
| name: "linkPath", | ||
| type: "string", | ||
| desc: "A url path to a project or some other page. I.e. /{office}/projects/ would end up pointing to /{office}/projects/{name}", |
There was a problem hiding this comment.
Looks like this doesn't want a trailing slash, so /{office}/projects is probably a better example. Also, maybe use {location} instead of {name} (just to use consistent CWMS terminology).
2 participants
This PR adds a data status component that uses quality codes returned via the timeseries endpoint to show a graphical bar line of quality codes at a glance.
It is similar to the DataStatusSummary.exe program within CWMS.
This allows districts to provide a path to a new line delimited file or an array of timeseries to be shown at a glance.
Thoughts