Open
Conversation
Contributor
krowvin
commented
Dec 18, 2025
krowvin
commented
- Creates how to steps for getting started with library contributions
- Merges contributing docs from readme into contributing file
- Adds badges to main page
jbkolze
requested changes
Jan 5, 2026
Collaborator
jbkolze
left a comment
jbkolze
left a comment
There was a problem hiding this comment.
Looks good! Few minor comments for clarity and grammar.
|
|
||
| These are the components that would be shared with the community but also within the docs themselves for testing and to showcase the components. | ||
|
|
||
| ### Publishing |
Collaborator
There was a problem hiding this comment.
This should probably be a level-2 header -- right now it's under "Working Directories".
Collaborator
There was a problem hiding this comment.
Think we might have missed this one (Publishing)? Or if it's by design just let me know.
jbkolze
requested changes
Jan 6, 2026
Collaborator
jbkolze
left a comment
jbkolze
left a comment
There was a problem hiding this comment.
Looks good -- just one heading that still looks a little off to me.
|
|
||
| These are the components that would be shared with the community but also within the docs themselves for testing and to showcase the components. | ||
|
|
||
| ### Publishing |
Collaborator
There was a problem hiding this comment.
Think we might have missed this one (Publishing)? Or if it's by design just let me know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.