Skip to content

Conversation

@TrifanBogdan24
Copy link

@TrifanBogdan24 TrifanBogdan24 commented Jan 8, 2024

Discussed topics

  • printing text
  • writing text
  • reading text from console
  • command line arguments
  • LINUX environment variables

Solved issue:

The new explanations are described both in English and Romanian.

@TrifanBogdan24 TrifanBogdan24 marked this pull request as ready for review January 8, 2024 17:01
@TrifanBogdan24
Copy link
Author

All the other chapters are not modified

@TrifanBogdan24 TrifanBogdan24 mentioned this pull request Jan 8, 2024
@TrifanBogdan24
Copy link
Author

Thank you D9nni for the feedback, I hope it is all right now.

@alexandruradovici
Copy link

State in the description that you added a chapter to the tutorials.

Copy link

@alexandruradovici alexandruradovici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify the translations for chapter 10 also.

Copy link

@D9nni D9nni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review for romanian translation.

@alexandruradovici
Copy link

@TrifanBogdan24 please mark the changes that you made as resolved.

Copy link

@alexandruradovici alexandruradovici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename all the chapter_10.yaml files to chapter_11.yaml as all the translations have to shift.

Copy link

@alexandruradovici alexandruradovici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase this so you can send it to upstream.

@TrifanBogdan24
Copy link
Author

I hope that my branch new-chapter is rebased

@TrifanBogdan24
Copy link
Author

Here is the link to the upstream: richardanaya#516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants