forked from markdwags/Razor
-
Notifications
You must be signed in to change notification settings - Fork 6
Fixed razor "lost/blocked target cursor" bug with script targeting #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Tranq1
wants to merge
58
commits into
UOOutlands:outlands
Choose a base branch
from
Tranq1:fixed-razor-target-bug
base: outlands
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop using the ConfigurationManager because that file changes when the program is run. This makes it difficult for launchers to ship good settings files.
This allows us to shift a bunch of code out of the packet handlers and into the individual files that handle each of these features.
fix dummy save Fix getName
To get local variables, just put unsetvar at the end of the script. Fixes UOOutlands#37
Dead feature. Hasn't been used in a decade.
rename expresson blessed with invul
…ing to InvalidOperationException
…st executed the "Set Last Target" hotkey and use the target <serial> command
Author
|
Apparently there's still some cases where the fix doesn't work, I'll look into it again |
…ut not regenerate the overriden one if there was a target previous target cursor
Author
|
Fixed second instance of the bug appearing when having a non-intercept target cursor up (for example a spell), then using the |
|
Merged to Client 11/22.2021 by Jaedan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug where previous natural target would be lost if a script first executed the
Set Last Targethotkey and use thetarget <serial>script commandTo reproduce the bug:
Note: If you remove the second line and target the hotkey manually, your previous spell target will return
Note: If you cancel the "Set Last Target" hotkey by pressing ESC, the previous spell target will also return
Note: This situation happens every time you target an intercepted target via the
targetcommand, not just with theSet Last TargethotkeyThe script:
What this fix does
With this fix, the target will also be returned after executing a target by the script, thus making it consistent with manually targeting the intercepted targets or canceling the intercepted target with ESC