Skip to content

Conversation

@Tranq1
Copy link

@Tranq1 Tranq1 commented Nov 11, 2021

Fixed bug where previous natural target would be lost if a script first executed the Set Last Target hotkey and use the target <serial> script command

To reproduce the bug:

  1. Cast a spell
  2. Add a variable "mytarget" to the script variables and set it to anything in sight, close and not yourself
  3. When the target cursor is up, execute the script.
  4. The last target hotkey is executed, but your previous target is gone.

Note: If you remove the second line and target the hotkey manually, your previous spell target will return
Note: If you cancel the "Set Last Target" hotkey by pressing ESC, the previous spell target will also return
Note: This situation happens every time you target an intercepted target via the target command, not just with the Set Last Target hotkey

The script:

hotkey "Set Last Target"
target mytarget

What this fix does

With this fix, the target will also be returned after executing a target by the script, thus making it consistent with manually targeting the intercepted targets or canceling the intercepted target with ESC

Jaedan and others added 30 commits August 15, 2021 21:29
Stop using the ConfigurationManager because that file changes when the
program is run. This makes it difficult for launchers to ship good
settings files.
This allows us to shift a bunch of code out of the packet handlers and
into the individual files that handle each of these features.
fix dummy save

Fix getName
@Tranq1
Copy link
Author

Tranq1 commented Nov 12, 2021

Apparently there's still some cases where the fix doesn't work, I'll look into it again

…ut not regenerate the overriden one if there was a target previous target cursor
@Tranq1
Copy link
Author

Tranq1 commented Nov 12, 2021

Fixed second instance of the bug appearing when having a non-intercept target cursor up (for example a spell), then using the Set Last Target followed by the Last Hotkey hotkey. Now the previous target gets regenerated.

@Tranq1 Tranq1 changed the title Fixed razor "lost target" bug with script targeting Fixed razor "lost/blocked target cursor" bug with script targeting Nov 12, 2021
@anethus
Copy link

anethus commented Dec 11, 2021

Merged to Client 11/22.2021 by Jaedan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants