Conversation
Contributor
Author
|
Creo que una optimización importante puede ser puentear el notificationscondition_activitystudentend_observer |
Contributor
Author
|
Hola. ¿Este PR está incluido en los cambios actuales? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problema: Se ha detectado alta carga acumulada en un curso sin reglas activadas. Se diagnostica que está causado por las consultas innecesarias en los observer de eventos course_viewed y module_viewed.
Solución: minimizar las atualizaciones de triggers en los observers.
En este PR propongo unos cambios para que:
Suposiciones de esta lógica:
a) El código del observer solo debe ejecutarse una vez por cada userid-courseid.
b) Las demás reconfiguraciones de los triggers se realizan con las operaciones de alta, baja y modificaciones de las reglas de forma estandar desde el motor de reglas.
Por favor, revisar.